Skip to content

Clean Code for ant/org.eclipse.ant.ui#1897

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/ant/org.eclipse.ant.ui
Jun 6, 2025
Merged

Clean Code for ant/org.eclipse.ant.ui#1897
akurtakov merged 2 commits into
masterfrom
clean-code/ant/org.eclipse.ant.ui

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
runtime/features/org.eclipse.core.runtime.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 75d1a6e1883c774c395d5732dac035695c733e77 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 6 Jun 2025 04:37:53 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
index f346fb237a..5ba2810b4d 100644
--- a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
+++ b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.ui; singleton:=true
-Bundle-Version: 3.10.100.qualifier
+Bundle-Version: 3.10.200.qualifier
 Bundle-Activator: org.eclipse.ant.internal.ui.AntUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/runtime/features/org.eclipse.core.runtime.feature/feature.xml b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
index be6874fea0..5e0968005c 100644
--- a/runtime/features/org.eclipse.core.runtime.feature/feature.xml
+++ b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.core.runtime.feature"
       label="%featureName"
-      version="1.4.800.qualifier"
+      version="1.4.900.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 30m 14s ⏱️ + 4m 37s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 328bc01. ± Comparison against base commit 917ba29.

@akurtakov
Copy link
Copy Markdown
Member

Quite a change!

@akurtakov akurtakov merged commit f4e6c12 into master Jun 6, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ant/org.eclipse.ant.ui branch June 6, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants