Skip to content

Clean Code for debug/org.eclipse.core.variables #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Jun 6, 2025
Merged

Clean Code for debug/org.eclipse.core.variables #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882cfd7
Perform clean code of debug/org.eclipse.core.variables
eclipse-platform-bot Jun 6, 2025
d117f9c
Version bump(s) for 4.37 stream
eclipse-platform-bot Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debug/org.eclipse.core.variables/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.core.variables; singleton:=true
Bundle-Version: 3.6.500.qualifier
Bundle-Version: 3.6.600.qualifier
Bundle-Activator: org.eclipse.core.variables.VariablesPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
3 changes: 1 addition & 2 deletions ...ipse.core.variables/src/org/eclipse/core/internal/variables/ContributedValueVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ private void initialize() {
if (className != null) {
try {
Object object = getConfigurationElement().createExecutableExtension("initializerClass"); //$NON-NLS-1$
if (object instanceof IValueVariableInitializer) {
IValueVariableInitializer initializer = (IValueVariableInitializer)object;
if (object instanceof IValueVariableInitializer initializer) {
initializer.initialize(this);
} else {
VariablesPlugin.logMessage(NLS.bind("Unable to initialize variable {0} - initializer must be an instance of IValueVariableInitializer.", new String[]{getName()}), null); //$NON-NLS-1$
Expand Down
6 changes: 2 additions & 4 deletions ...eclipse.core.variables/src/org/eclipse/core/internal/variables/StringVariableManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ private void loadDynamicVariables() {
if (old != null) {
DynamicVariable oldVariable = (DynamicVariable)old;
VariablesPlugin.logMessage(NLS.bind("Dynamic variable extension from bundle ''{0}'' overrides existing extension variable ''{1}'' from bundle ''{2}''", //$NON-NLS-1$
new String[] {element.getDeclaringExtension().getContributor().getName(),oldVariable.getName(),
oldVariable.getConfigurationElement().getDeclaringExtension().getContributor().getName()}), null);
element.getDeclaringExtension().getContributor().getName(), oldVariable.getName(), oldVariable.getConfigurationElement().getDeclaringExtension().getContributor().getName()), null);
}
}
}
Expand All @@ -258,8 +257,7 @@ private void loadContributedValueVariables() {
if (old != null) {
StringVariable oldVariable = (StringVariable)old;
VariablesPlugin.logMessage(NLS.bind("Contributed variable extension from bundle ''{0}'' overrides existing extension variable ''{1}'' from bundle ''{2}''", //$NON-NLS-1$
new String[] {element.getDeclaringExtension().getContributor().getName(),oldVariable.getName(),
oldVariable.getConfigurationElement().getDeclaringExtension().getContributor().getName()}), null);
element.getDeclaringExtension().getContributor().getName(), oldVariable.getName(), oldVariable.getConfigurationElement().getDeclaringExtension().getContributor().getName()), null);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion runtime/features/org.eclipse.core.runtime.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="org.eclipse.core.runtime.feature"
label="%featureName"
version="1.4.800.qualifier"
version="1.4.900.qualifier"
provider-name="%providerName"
license-feature="org.eclipse.license"
license-feature-version="0.0.0">
Expand Down
Loading