Skip to content

Clean Code for debug/org.eclipse.debug.examples.core #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Jun 6, 2025
Merged

Clean Code for debug/org.eclipse.debug.examples.core #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89e30d
Perform clean code of debug/org.eclipse.debug.examples.core
eclipse-platform-bot Jun 6, 2025
176c75c
Version bump(s) for 4.37 stream
eclipse-platform-bot Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: org.eclipse.debug.examples.core;singleton:=true
Bundle-Version: 1.6.500.qualifier
Bundle-Version: 1.6.600.qualifier
Bundle-Activator: org.eclipse.debug.examples.core.pda.DebugCorePlugin
Require-Bundle: org.eclipse.core.runtime,
org.eclipse.core.resources,
Expand Down
3 changes: 2 additions & 1 deletion ....eclipse.debug.examples.core/src/org/eclipse/debug/examples/core/pda/DebugCorePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@ public static String getResourceString(String key) {
*/
public ResourceBundle getResourceBundle() {
try {
if (resourceBundle == null)
if (resourceBundle == null) {
resourceBundle = ResourceBundle.getBundle("org.eclipse.debug.examples.core.pda.DebugCorePluginResources"); //$NON-NLS-1$
}
} catch (MissingResourceException x) {
resourceBundle = null;
}
Expand Down
4 changes: 2 additions & 2 deletions ...bug.examples.core/src/org/eclipse/debug/examples/core/pda/launcher/PDALaunchDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public void launch(ILaunchConfiguration configuration, String mode, ILaunch laun
}
File exe = new File(javaVMExec);
if (!exe.exists()) {
abort(MessageFormat.format("Specified java VM executable {0} does not exist.", new Object[]{javaVMExec}), null); //$NON-NLS-1$
abort(MessageFormat.format("Specified java VM executable {0} does not exist.", javaVMExec), null); //$NON-NLS-1$
}
commandList.add(javaVMExec);

Expand All @@ -80,7 +80,7 @@ public void launch(ILaunchConfiguration configuration, String mode, ILaunch laun

IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(IPath.fromOSString(program));
if (!file.exists()) {
abort(MessageFormat.format("Perl program {0} does not exist.", new Object[] { file.getFullPath().toString() }), null); //$NON-NLS-1$
abort(MessageFormat.format("Perl program {0} does not exist.", file.getFullPath().toString()), null); //$NON-NLS-1$
}

commandList.add(file.getLocation().toOSString());
Expand Down
3 changes: 1 addition & 2 deletions ...ipse.debug.examples.core/src/org/eclipse/debug/examples/core/pda/model/PDAStackFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ public String getSourceName() {

@Override
public boolean equals(Object obj) {
if (obj instanceof PDAStackFrame) {
PDAStackFrame sf = (PDAStackFrame)obj;
if (obj instanceof PDAStackFrame sf) {
return sf.getThread().equals(getThread()) &&
sf.getSourceName().equals(getSourceName()) &&
sf.fId == fId;
Expand Down
3 changes: 1 addition & 2 deletions ....eclipse.debug.examples.core/src/org/eclipse/debug/examples/core/pda/model/PDAThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,7 @@ public Object getError() {

@Override
public void handleEvent(PDAEvent _event) {
if (_event instanceof PDARunControlEvent && fThreadId == ((PDARunControlEvent)_event).fThreadId) {
PDARunControlEvent event = (PDARunControlEvent)_event;
if (_event instanceof PDARunControlEvent event && fThreadId == event.fThreadId) {
// clear previous state
fBreakpoint = null;
setStepping(false);
Expand Down
2 changes: 1 addition & 1 deletion runtime/features/org.eclipse.core.runtime.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="org.eclipse.core.runtime.feature"
label="%featureName"
version="1.4.800.qualifier"
version="1.4.900.qualifier"
provider-name="%providerName"
license-feature="org.eclipse.license"
license-feature-version="0.0.0">
Expand Down
Loading