Clean Code for update/org.eclipse.update.configurator

[eclipse-platform-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[github-actions]

Test Results

 1 920 files   -  27   1 920 suites   - 27   1h 32m 47s ⏱️ + 1m 16s
 4 717 tests ±  0   4 692 ✅  -   1   24 💤 ±0  1 ❌ +1 
13 998 runs   - 153  13 830 ✅  - 154  167 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 742066b. ± Comparison against base commit 731e745.

♻️ This comment has been updated with latest results.

[HeikoKlare]

The changes are fine except for the removal of the warning suppressions. I was not able to take a long into why they are erroneously removed yet.

[laeubi]

The changes are fine except for the removal of the warning suppressions. I was not able to take a long into why they are erroneously removed yet.

@jjohnstn do you have a hint why they are removed?

[HeikoKlare]

I forgot to mentioned that I have already created a JDT issue:

• Cleanup "remove unnecessary suppress warnings tokens" does not properly consider "removal" eclipse-jdt/eclipse.jdt.ui#2271

The problem only occurs with "removal" suppressions, not with "deprecation" and the like.