Skip to content

Remove requirement of inlined o.e.jdt.launching.macosx fragment#2753

Merged
HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:remove-jdt.launching.macosx-requirement
Jun 9, 2026
Merged

Remove requirement of inlined o.e.jdt.launching.macosx fragment#2753
HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:remove-jdt.launching.macosx-requirement

Conversation

@HannesWell

Copy link
Copy Markdown
Member

@vogella

vogella commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

I think that is what currently fails the aggregator build, eclipse-platform/eclipse.platform.releng.aggregator#3888

Thanks!

@HannesWell

Copy link
Copy Markdown
Member Author

I think that is what currently fails the aggregator build, eclipse-platform/eclipse.platform.releng.aggregator#3888

Yes it is. But since there is some chicken-egg problem when resolving the removal/inlining of the previous needed fragment there is no (trivial) perfect way to do it and this will probably fail some tests until the inlining has passed an I-build.
But since verification builds of multiple repositories will fail with this applied I decided to do it close to the I-build start.
The aggregator verification build failing over the day was IMO the smaller collateral damage.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   50m 57s ⏱️ - 3m 6s
 4 671 tests ±0   4 618 ✅  - 31   22 💤 ±0  30 ❌ +30  1 🔥 +1 
11 907 runs  ±0  11 723 ✅  - 31  153 💤 ±0  30 ❌ +30  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 0648b71. ± Comparison against base commit abad270.

@HannesWell

Copy link
Copy Markdown
Member Author

Test failures on Mac are expected because the inlined code of the fragment is only available in the new target bundle after tonight's I-build.

@HannesWell HannesWell merged commit 3c5914a into eclipse-platform:master Jun 9, 2026
16 of 18 checks passed
@HannesWell HannesWell deleted the remove-jdt.launching.macosx-requirement branch June 9, 2026 17:57
@vogella

vogella commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the update, yes a aggregator failing for a day or so is fine IMHO for such a nice improvement. Thanks for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants