Introduce icon mapping to avoid duplicates in icon packs #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a semantic icon library and a mapping configuration to avoid duplicate icons in icon packs. The semnatic icon library contains an entry for every unique icon and a description of it's purpose. The mapping configuration maps every unique icon to all currently existing eclipse icons that should be replaced by the unique icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adds a semantic icon library and a mapping configuration to avoid duplicate icons in icon packs.
The semantic icon library contains an entry for every unique icon and a description of it's purpose. The mapping configuration maps every unique icon to all currently existing eclipse icons that should be replaced by the unique icon.
Also all already designed icons for the dual tone icon pack will be renamed to the unique semantic icon name described in the semantic icon library.
Please be aware that not all icons are described in the library yet and the rest will follow soon.
This draft can still be used for the refinement of the approach that @laeubi proposed in this discussion.