Refresh root when change notification hast no items (#14868)

Fixes #14851 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
eclipse-theia · Feb 11, 2025 · 984d95d · 984d95d
1 parent ccbc71a
commit 984d95d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/packages/plugin-ext/src/common/plugin-api-rpc.ts b/packages/plugin-ext/src/common/plugin-api-rpc.ts
@@ -822,7 +822,7 @@ export interface TreeViewsMain {
     $registerTreeDataProvider(treeViewId: string, options?: RegisterTreeDataProviderOptions): void;
     $readDroppedFile(contentId: string): Promise<BinaryBuffer>;
     $unregisterTreeDataProvider(treeViewId: string): void;
-    $refresh(treeViewId: string, itemIds: string[]): Promise<void>;
+    $refresh(treeViewId: string, itemIds?: string[]): Promise<void>;
     $reveal(treeViewId: string, elementParentChain: string[], options: TreeViewRevealOptions): Promise<any>;
     $setMessage(treeViewId: string, message: string): void;
     $setTitle(treeViewId: string, title: string): void;

diff --git a/packages/plugin-ext/src/main/browser/view/tree-views-main.ts b/packages/plugin-ext/src/main/browser/view/tree-views-main.ts
@@ -110,7 +110,7 @@ export class TreeViewsMainImpl implements TreeViewsMain, Disposable {
         return BinaryBuffer.wrap(new Uint8Array(buffer));
     }
 
-    async $refresh(treeViewId: string, items: string[]): Promise<void> {
+    async $refresh(treeViewId: string, items?: string[]): Promise<void> {
         const viewPanel = await this.viewRegistry.getView(treeViewId);
         const widget = viewPanel && viewPanel.widgets[0];
         if (widget instanceof TreeViewWidget) {

diff --git a/packages/plugin-ext/src/plugin/tree/tree-views.ts b/packages/plugin-ext/src/plugin/tree/tree-views.ts
@@ -253,21 +253,25 @@ class TreeViewExtImpl<T> implements Disposable {
         });
         this.toDispose.push(Disposable.create(() => this.proxy.$unregisterTreeDataProvider(treeViewId)));
         options.treeDataProvider.onDidChangeTreeData?.(elements => {
-            const ids = [];
-            elements = elements || [];
-            if (!Array.isArray(elements)) {
-                elements = [elements];
-            }
-            const set = new Set<T>();
-            for (const element of elements) {
-                set.add(element);
-            }
-            for (const node of this.nodes.values()) {
-                if (node.value && set.has(node.value)) {
-                    ids.push(node.id);
+            if (!elements) {
+                this.pendingRefresh = proxy.$refresh(treeViewId);
+            } else {
+                const ids = [];
+                elements = elements || [];
+                if (!Array.isArray(elements)) {
+                    elements = [elements];
+                }
+                const set = new Set<T>();
+                for (const element of elements) {
+                    set.add(element);
+                }
+                for (const node of this.nodes.values()) {
+                    if (node.value && set.has(node.value)) {
+                        ids.push(node.id);
+                    }
                 }
+                this.pendingRefresh = proxy.$refresh(treeViewId, ids);
             }
-            this.pendingRefresh = proxy.$refresh(treeViewId, ids);
         });
     }