[vscode] Support evolution on proposed API extensionAny #14199
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschnekenbu
force-pushed
the
issues/14115
branch
from
f655917
to
02746fe
Compare
fixes eclipse-theia#14115 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
issues/14115
branch
from
02746fe
to
cd0e5af
Compare
tsmaeder
approved these changes
Sep 20, 2024
| @@ -41,9 +41,13 @@ export module '@theia/plugin' { | |||
| * @param extensionId An extension identifier. | |||
| * @param includeDifferentExtensionHosts Include extensions from different extension host | |||
| * @return An extension or `undefined`. | |||
| * | |||
| * *Note* In Theia, includeDifferentExtensionHosts will always be set to false, as we only support one host currently. | |||
There was a problem hiding this comment.
That is actually not true: we support at least two different extension hosts: front-end and back-end. Back in the Che days, there was even support for remote-calling the extension interface via RPC.
|
@sdirix since you're Mr. "browser-only-Theia", would it make sense to do a follow-up to this PR that actually implements the functionality for multiple extensions hosts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Proposed API extensionsAny will now have a new signature for getExtension:
https://github.com/microsoft/vscode/blob/38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40/src/vscode-dts/vscode.proposed.extensionsAny.d.ts#L31
This Pull Request adds this to the similar interface in Theia file, and also update getExtension from plugin-context to align with this new signature.
Since #12277, the
includeDifferentExtensionHostsparameter is ignored, as there is only one host in Theia. So there should be no other change to support this evolution.fixes #14115
contributed on behalf of STMicroelectronics
How to test
Use the builtins and assume they still work with this evolution. The html-language-feature is the only builtin relying on the extensionsAny proposed API.
Follow-ups
None
Review checklist
Reminder for reviewers