open local workspaces, files and folders in remote #14607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
changed the title
msujew
reviewed
Dec 11, 2024
| @@ -81,5 +84,11 @@ export default new ContainerModule((bind, _, __, rebind) => { | |||
| bind(LocalRemoteFileSystemProvider).toSelf().inSingletonScope(); | |||
| rebind(UserStorageContribution).to(RemoteUserStorageContribution); | |||
|
|
|||
| if (isRemote) { | |||
| rebind(WorkspaceService).to(RemoteWorkspaceService).inSingletonScope(); | |||
There was a problem hiding this comment.
Suggestion: This should rather be a contribution, instead of a rebinding. See also the existing rebinding in the collaboration package
and the related issue #14080.
|
@jonah-iden What is the state of this PR? |
|
@JonasHelming Seems i've forgotten about this one. Still need adress the review comments. I'll try and take care of that next time i have some open-source time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implements #14574
This does 2 things regarding opening workspaces when connected to a remote.
open recent workspacesand allows opening them even when connected to a remoteHow to test
Connect to a remote or dev-container.
select
file -> Open Recent Workspace...see the list should be equal to the list you see locally.
Workspaces should be openable both dev-container and normal files/folders
Connect to a remote or dev-container.
use the
file -> Open Folder...option.See there should be a new button
Show LocalClick to see a new file dialog opening showing the local file system
Selecting the folder disconnects the remote and opens the workspace or opens a new window with the selected workspace (depending on settings)
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers