Use default import of fix-path package

[msujew]

What it does

Closes #14804

Correctly uses the default import of the fix-path library. Since the 4.0.0 version is an ESM library, we need to call default() explicitly. Additionally adjusts the imports used in the generated code to ensure that non-hoisting of libraries does not result in errors.

How to test

1. Clean your Theia node_modules, ideally using something like git clean -xfd
2. Run npm i && npm run build:electron && npm run start:electron
3. Everything should work as expected.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[rschnekenbu]

Electron app starts well with this patch. Thanks @msujew!

[kittaakos]

Thank you! I verified it with 0d902cc, and it worked well.

---

From the main branch (17d4667), I received the same error when I ran npm run all:

ERROR in ./src-gen/backend/electron-main.js 9:0-19
Module not found: Error: Can't resolve 'fix-path' in '/Users/kittaakos/dev/git/theia/examples/electron/src-gen/backend'
resolve 'fix-path' in '/Users/kittaakos/dev/git/theia/examples/electron/src-gen/backend'
  Parsed request is a module
  using description file: /Users/kittaakos/dev/git/theia/examples/electron/package.json (relative path: ./src-gen/backend)
    resolve as module
      /Users/kittaakos/dev/git/theia/examples/electron/src-gen/backend/node_modules doesn't exist or is not a directory
      /Users/kittaakos/dev/git/theia/examples/electron/src-gen/node_modules doesn't exist or is not a directory
      /Users/kittaakos/dev/git/theia/examples/electron/node_modules doesn't exist or is not a directory
      /Users/kittaakos/dev/git/theia/examples/node_modules doesn't exist or is not a directory
      looking for modules in /Users/kittaakos/dev/git/theia/node_modules
        single file module
          using description file: /Users/kittaakos/dev/git/theia/package.json (relative path: ./node_modules/fix-path)
            no extension
              /Users/kittaakos/dev/git/theia/node_modules/fix-path doesn't exist
            .js
              /Users/kittaakos/dev/git/theia/node_modules/fix-path.js doesn't exist
            .json
              /Users/kittaakos/dev/git/theia/node_modules/fix-path.json doesn't exist
            .wasm
              /Users/kittaakos/dev/git/theia/node_modules/fix-path.wasm doesn't exist
        /Users/kittaakos/dev/git/theia/node_modules/fix-path doesn't exist
      /Users/kittaakos/dev/git/node_modules doesn't exist or is not a directory
      /Users/kittaakos/dev/node_modules doesn't exist or is not a directory
      /Users/kittaakos/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory

[jfaltermeier]

LGTM, the Electron app starts as expected.

[sdirix]

@msujew @jfaltermeier Note that this a webpack-based solution if I'm not mistaken. So we should mark in the changelog that bundling the backend is now mandatory, as otherwise the Electron startup will fail.

[msujew]

@sdirix Um, yes you're right. However, I believe that without a bundler, the backend fails to load anyway, since the fix-path cannot be required in standard node.js, as it is a ESM library.

@tsmaeder All the more reason to switch to ESM ;)

[sdirix]

@msujew The previously used fix-path was commonjs, so there it worked. We got into the problem now with the fix-path upgrade as it is now an ESM version. So it's not the consequence of this PR, but the one which did the upgrade that we now require bundling. Either way, it should be mentioned as a breaking change for the new version of Theia.