-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(ai): ensure that tool calls batched in a single turn always run in parallel #17623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cdamus
wants to merge
11
commits into
master
Choose a base branch
from
issue/17533-parallel-toolcalls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
eee047e
feat(ai): execute a turn's tool calls concurrently via a shared ToolC…
cdamus b22f9cb
fix(ai-chat): dispose per-content change listeners on clearContent
cdamus 2084318
feat(ai): run OpenAI Chat Completions & Copilot tool calls concurrently
cdamus 52a91da
Merge remote-tracking branch 'origin/master' into issue/17533-paralle…
cdamus a1d58e4
chore(ai): drop pointless comments
cdamus 318b3ad
refactor(ai-core): rename low-level tool-call interfaces
cdamus 70753c5
refactor(ai-core): refactor ToolCallExecutor as an interface
cdamus f9a2064
refactor(ai-core): bind ToolCallExecutor in the root container
cdamus bdd40f2
refactor(ai-openai): drop the maxChatCompletions turn cap
cdamus 02afdc2
refactor(ai): bind provider models as injectable services
cdamus 221f8db
Merge remote-tracking branch 'origin/master' into issue/17533-paralle…
cdamus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change, I wanted to use a factory approach for a longer time now. Which is one of the reasons I brought up #17520.
Personally I would like if it goes a step further and makes the model itself
@injectabletoo. The params can then be injected as an object and the tool call executor would be injected separately.