feat: add wildcard support for logger configuration by ankitsharma101 · Pull Request #17627 · eclipse-theia/theia

ankitsharma101 · 2026-06-05T14:07:51Z

What it does

This PR introduces wildcard and regex support for logger configuration, allowing developers to configure multiple loggers using a single rule (e.g., "ai-core*": "error", "*Token*": "warn") without needing to explicitly list every sub-service.

Implementation Details:

Added wildcardRegexCache to LogLevelCliContribution to ensure regex compilation only happens once per pattern for optimal performance.
Updated logLevelFor to iterate through configured levels, respecting the "last one wins" rule for wildcard specificity.
Added getWildcardRegex to safely escape standard regex characters in the user's config before injecting the .* wildcard matcher.
Test Refactor: Cleaned up legacy unhandled Promises in older setArguments tests to ensure strict type compliance and reliable CLI fallbacks.

How to test

1. Automated Tests
Run the core test suite to verify the new wildcard matching logic and the patched legacy tests:
yarn --cwd packages/core test

2. End-to-End Test
A sample log-config.json has been added to the browser example.

Navigate to the browser example: cd examples/browser
Build the application: yarn build
Start the application: yarn start
Observe the terminal output. You should see Successfully read new log config from .../log-config.json and notice that the plugin loggers perfectly respect the wildcard rules defined in the file.

Follow-ups

None currently identified. The regex cache ensures this scales well even if developers provide massive configuration files.

Breaking changes

This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

As an author, I have thoroughly tested my changes and carefully followed the review guidelines
User-facing text is internationalized using the nls service (for details, please see the Internationalization/Localization section in the Coding Guidelines)

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

sdirix

Thanks for this first implementation. Please see my comments.

ankitsharma101 · 2026-06-08T15:24:07Z

Thanks for the thorough review, Stefan! I've fully addressed your feedback across the board:

Memory Leak: Added a cache.clear() call inside slurpLogConfigFile so the cache cleanly wipes whenever a user modifies the log configuration file at runtime.

Performance Optimization: Refactored logLevelFor to execute a fast O(1) perfect match lookup upfront. If an exact match isn't present, it iterates through the keys backward and short-circuits on the first wildcard match to respect the "last one wins" specificity rule efficiently.

Test Refactor: Cleaned up the testing architecture. The wildcard tests no longer mutate private state using as unknown as Record<string, unknown> and instead leverage a helper that tests everything cleanly via the public CLI API.

Sensible Defaults: Updated the browser example log-config.json with a lightweight, realistic use case that won't obscure verbose logging during core active AI development.

Documentation: Documented the newly introduced wildcard feature, precedence tiers, and exact match priority within packages/core/README.md.

I also ran a full clean installation and environment purge locally—the entire core test suite is passing perfectly. Ready for another pass whenever you are!

sdirix

Documentation: Documented the newly introduced wildcard feature, precedence tiers, and exact match priority within packages/core/README.md.

The documentation change is not part of the current PR. Please add it.

ankitsharma101 · 2026-06-11T12:22:46Z

Everything is updated now. I reverted the unintended changes, got the wildcard docs into the README_TEMPLATE.md and passed all CI/CD tests and fixed a bug in regex matcher. Is everything good now? Will be working on the other PR in the meantime

sdirix

Code looks good! I just have comments regarding the script, test and documentation

sdirix · 2026-06-11T14:03:13Z

    "coverage:report": "nyc report --reporter=html",
    "rebuild": "theia rebuild:browser --cacheRoot ../..",
-    "start": "theia start --plugins=local-dir:../../plugins --ovsx-router-config=../ovsx-router-config.json",
+    "start": "theia start --plugins=local-dir:../../plugins --ovsx-router-config=../ovsx-router-config.json --log-config=log-config.json",


I realized that this conflicts with the --log-level=debug of the start:debug script. I think we should introduce a new start:plugins script (with the current content of start) and then in start we do npm run -s start:plugins -- --log-config=log-config.json and in start:debug we also use start:plugins

sdirix · 2026-06-11T14:03:14Z

+            await cli.setArguments(args);
+        }
+
+        it('should respect exact matches if they are evaluated last (or only)', async () => {


Test name is misleading: this case has only an exact entry, so it never exercises the "evaluated last"

sdirix · 2026-06-11T14:49:03Z

    "terminal": "debug",
-    "task": "error"
+    "task": "error",


Task and terminal will no longer work, so I would use wildcards for them too

sdirix · 2026-06-11T14:49:41Z

+    "ai-core:DefaultPromptFragmentCustomizationService": "debug",
+    "ai-core*": "error",


I would change their order just to establish the generic to specialized recommendation

Suggested change

"ai-core:DefaultPromptFragmentCustomizationService": "debug",

"ai-core*": "error",

"ai-core*": "error",

"ai-core:DefaultPromptFragmentCustomizationService": "debug",

sdirix · 2026-06-11T14:50:17Z

    "terminal": "debug",
-    "task": "error"
+    "task": "error",
+    "ai-core:DefaultPromptFragmentCustomizationService": "debug",
+    "ai-core*": "error",
+    "*Token*": "warn"


same comments here

…wildcard support and precedence rules to loging config and

ankitsharma101 · 2026-06-11T22:02:26Z

I've addresssed the script conflicts and renamed the tests. I have also updated the wildcard ocumentation as per the suggestions. Ready for the re-review.

sdirix

Looks good. However I saw that we already have a regex escape util, so we should reuse that.

sdirix · 2026-06-15T09:28:55Z

+    protected getWildcardRegex(pattern: string): RegExp {
+        let regex = this.wildcardRegexCache.get(pattern);
+        if (!regex) {
+            const escapedPattern = pattern.replace(/[.+?^${}()|[\]\\]/g, '\\$&');


Hi @ankitsharma101, I noticed that we already have a util for this:

theia/packages/core/src/common/strings.ts

Line 113 in d6f4563

export function escapeRegExpCharacters(value: string): string {

. It also escapes *, so you can split on the wildcard first and reuse it: pattern.split('*').map(escapeRegExpCharacters).join('.*').

Thanks for pointing that out, Stefan! I've removed the custom regex and am reusing escapeRegExpCharacters instead. Let me know if everything looks good to merge now!

github-project-automation Bot added this to PR Backlog Jun 5, 2026

github-project-automation Bot moved this to Waiting on reviewers in PR Backlog Jun 5, 2026

feat: add wildcard and regex support for logger configuration

f047a40

ankitsharma101 force-pushed the feature/logger-wildcard-support branch from dabcea8 to f047a40 Compare June 5, 2026 14:21

Merge branch 'master' into feature/logger-wildcard-support

ea4abf1

sdirix self-requested a review June 8, 2026 10:23

sdirix requested changes Jun 8, 2026

View reviewed changes

github-project-automation Bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Jun 8, 2026

ankitsharma101 added 2 commits June 8, 2026 15:08

fix: address PR review feedback for logger wildcards

7612340

fix: address PR review feedback for logger wildcards

0dc1647

ankitsharma101 requested a review from sdirix June 8, 2026 18:42

sdirix requested changes Jun 10, 2026

View reviewed changes

Comment thread packages/core/src/node/logger-cli-contribution.ts Outdated

ankitsharma101 force-pushed the feature/logger-wildcard-support branch from 56f6ef5 to 577e822 Compare June 11, 2026 12:00

sdirix changed the title ~~feat: add wildcard and regex support for logger configuration~~ feat: add wildcard support for logger configuration Jun 11, 2026

sdirix requested changes Jun 11, 2026

View reviewed changes

resolved reeview feedback, corected regex pattern matching and added …

0a25f90

…wildcard support and precedence rules to loging config and

ankitsharma101 force-pushed the feature/logger-wildcard-support branch from 577e822 to 0a25f90 Compare June 11, 2026 21:58

ankitsharma101 requested a review from sdirix June 11, 2026 22:11

sdirix requested changes Jun 15, 2026

View reviewed changes

refactor: use built-in escapeRegExpCharacters utility

b8e72da

ankitsharma101 requested a review from sdirix June 15, 2026 09:55

		"ai-core:DefaultPromptFragmentCustomizationService": "debug",
		"ai-core*": "error",

Conversation

ankitsharma101 commented Jun 5, 2026

What it does

How to test

Follow-ups

Breaking changes

Attribution

Review checklist

Reminder for reviewers

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ankitsharma101 commented Jun 8, 2026

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ankitsharma101 commented Jun 11, 2026

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

ankitsharma101 commented Jun 11, 2026

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

sdirix Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

ankitsharma101 Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants