Conversation
Resolves GH-17664 - compare the requested location against the live current location in `trySetNewLocation` instead of a cached `lastUniqueTextInputLocation` - the cached value went stale after navigating via the Up/Back/Forward/Home buttons or the tree, silently blocking navigation to a previously visited path typed into the location input - remove the now-unused `lastUniqueTextInputLocation` field - add regression tests for `trySetNewLocation` Contributed on behalf of STMicroelectronics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Resolves GH-17664
trySetNewLocationinstead of a cachedlastUniqueTextInputLocationlastUniqueTextInputLocationfieldtrySetNewLocationHow to test
Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers