Skip to content

fix(filesystem): fix file dialog location input navigation#17665

Open
ndoschek wants to merge 1 commit into
masterfrom
GH-17664
Open

fix(filesystem): fix file dialog location input navigation#17665
ndoschek wants to merge 1 commit into
masterfrom
GH-17664

Conversation

@ndoschek

Copy link
Copy Markdown
Member

What it does

Resolves GH-17664

  • compare the requested location against the live current location in trySetNewLocation instead of a cached lastUniqueTextInputLocation
  • the cached value went stale after navigating via the Up/Back/Forward/Home buttons or the tree, silently blocking navigation to a previously visited path typed into the location input
  • remove the now-unused lastUniqueTextInputLocation field
  • add regression tests for trySetNewLocation

How to test

  1. Start the example browser application
  2. Open a file dialog (e.g. File > Open... or Open Workspace...).
  3. Click the edit (pencil) icon to switch the location bar to text input.
  4. Type an absolute path, e.g. /home, and press Enter. The dialog navigates to /home.
  5. Move to a different folder without using the text input, for example click the Navigate Up button (or Back), or double-click a folder in the tree.
  6. Click the edit (pencil) icon again, type the same path as in step 3 (/home), and press Enter.
  7. Verify that everytime you enter a (valid) path manually, it is accepted and the file dialog navigates there

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

Resolves GH-17664

- compare the requested location against the live current location in
  `trySetNewLocation` instead of a cached `lastUniqueTextInputLocation`
- the cached value went stale after navigating via the Up/Back/Forward/Home
  buttons or the tree, silently blocking navigation to a previously visited
  path typed into the location input
- remove the now-unused `lastUniqueTextInputLocation` field
- add regression tests for `trySetNewLocation`

Contributed on behalf of STMicroelectronics
@github-project-automation github-project-automation Bot moved this to Waiting on reviewers in PR Backlog Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on reviewers

Development

Successfully merging this pull request may close these issues.

File dialog: editing the location path and pressing Enter does not navigate to a previously visited folder

1 participant