feat: implement anonymized planned production output by jakoballgaier · Pull Request #1099 · eclipse-tractusx/puris

jakoballgaier · 2026-03-04T12:42:42Z

Description

resolves #1079

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files (TRG 7.02
Documentation Notice are present on all affected files (TRG 7.07)
If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
Changelog updated (changelog.md) with PR reference and brief summary.
Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
Backend version bumped, if needed (backend/pom.xml)
Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

jakoballgaier · 2026-03-04T12:43:49Z

@ReneSchroederLJ
Unfortunately I was not able to build the OpenAPI.yaml on MacOS. It would be nice if you could generate it :)

...org/eclipse/tractusx/puris/backend/production/controller/ProductionRequestApiController.java

.../production/logic/dto/anonymizedplannedproductionsamm/PlannedProductionOutputAnonymized.java

ReneSchroederLJ

Overall great work. One minor thing on the db changelog and the tests need fixing. I will add the openAPI changes once everything else is done

ReneSchroederLJ · 2026-03-04T14:32:42Z

backend/src/main/resources/db/changelog/changelog-5.x/changelog-5.1.0.yaml

+databaseChangeLog:
+  - changeSet:
+        id: "1"
+        author: ReneSchroederLJ


Please update with your own GitHub user as author

ReneSchroederLJ · 2026-03-04T15:02:40Z

...eclipse/tractusx/puris/backend/production/logic/adapter/PlannedProductionSammMapperTest.java

+    }
+
+    @Test
+    void ownProductionToSamm_materialFlag_usesMprService() {


This test doesn't really make sense to me. ownProductionToSamm does not use the mprService

ReneSchroederLJ

The functionality itself works. Please change the target branch to feat/anonymized-data-exchange and rebase.

Also make sure the Unit tests are successful.

ReneSchroederLJ

I found some more small issues. Please fix.

Also please resolve conflicts and add the missing openAPI changes

ReneSchroederLJ · 2026-03-13T12:53:19Z

...org/eclipse/tractusx/puris/backend/production/controller/ProductionRequestApiController.java

        return ResponseEntity.ok(samm);
    }
+
+    @Operation(summary = "This endpoint receives the Planned Production Submodel 2.0.0 requests. " +


Suggested change

@Operation(summary = "This endpoint receives the Planned Production Submodel 2.0.0 requests. " +

@Operation(summary = "This endpoint receives the Anonymized Planned Production Submodel 1.0.0 requests. " +

ReneSchroederLJ · 2026-03-13T12:54:52Z

backend/src/main/resources/db/changelog/changelog-5.x/changelog-5.1.0.yaml

  - changeSet:
        id: "1"
-        author: ReneSchroederLJ
+        author: jakoballgaier


revert changed author please

ReneSchroederLJ · 2026-03-13T12:57:19Z

...eclipse/tractusx/puris/backend/production/logic/adapter/PlannedProductionSammMapperTest.java

+        assertNotNull(pos.getAllocatedPlannedProductionOutputs());
+        assertEquals(1, pos.getAllocatedPlannedProductionOutputs().size());
+        AllocatedPlannedProductionOutput p = pos.getAllocatedPlannedProductionOutputs().iterator().next();
+        assertEquals("BPNS123456789012", p.getProductionSiteBpns());


what about assertions for the other properties of production?

ReneSchroederLJ · 2026-03-13T12:58:21Z

...eclipse/tractusx/puris/backend/production/logic/adapter/PlannedProductionSammMapperTest.java

+        assertNotNull(samm);
+        assertTrue(samm.getMaterialGlobalAssetIdAnonymized().startsWith("enc:"));
+        assertNotNull(samm.getAllocatedPlannedProductionOutputs());
+        assertEquals(1, samm.getAllocatedPlannedProductionOutputs().size());


Same as above. The test should make sure that all properties of production are set properly.

ReneSchroederLJ · 2026-03-13T13:01:43Z

CHANGELOG.md

 - Added update flow to Material Details View buttons ([#1034](https://github.com/eclipse-tractusx/puris/pull/1034))
 - Added submodel implementation for delivery information anyonymized ([#1095](https://github.com/eclipse-tractusx/puris/pull/1095))
 - Added submodel implementation for item stock anyonymized ([#1096](https://github.com/eclipse-tractusx/puris/pull/1096))
+- Added submodel implementation for planned production output anyonymized ([#1099](https://github.com/eclipse-tractusx/puris/pull/1099))


Suggested change

- Added submodel implementation for planned production output anyonymized ([#1099](https://github.com/eclipse-tractusx/puris/pull/1099))

- Added submodel implementation for planned production output anonymized ([#1099](https://github.com/eclipse-tractusx/puris/pull/1099))

fix all 3 instances please

…tion-anonymized

ReneSchroederLJ

Works well just missed a small possible log injection.

ReneSchroederLJ · 2026-03-16T09:02:34Z

...org/eclipse/tractusx/puris/backend/production/controller/ProductionRequestApiController.java

+        @PathVariable String materialNumberCx,
+        @PathVariable String representation
+    ) {
+        log.info("Received request for Anonymized Planned Production with materialNumberCx: {} and representation: {} from bpnl: {}", materialNumberCx, representation, bpnl);


Please remove this log as it happens before any pattern matching is done and presents actual risk for log injection. My bad for missing this previously.

ReneSchroederLJ

The functionality works well now.

Please bump the helm and app versions to 7.0.0 and 6.0.0. respectively. Don't forget to also update the versions in the helm README.md and move the changes for this feature branch to a new changelog section

jakoballgaier requested a review from ReneSchroederLJ March 4, 2026 12:42

github-advanced-security bot found potential problems Mar 4, 2026

View reviewed changes

ReneSchroederLJ requested changes Mar 4, 2026

View reviewed changes

jakoballgaier requested a review from ReneSchroederLJ March 4, 2026 16:13

jakoballgaier self-assigned this Mar 6, 2026

ReneSchroederLJ requested changes Mar 6, 2026

View reviewed changes

jakoballgaier changed the base branch from main to feat/anonymized-data-exchange March 6, 2026 14:32

jakoballgaier added 2 commits March 6, 2026 15:59

feat: implement anonymized planned production output

beb805f

fix: PR changes

3655b6e

jakoballgaier force-pushed the feat/planned-production-anonymized branch from 73b7522 to 3655b6e Compare March 6, 2026 15:16

fix: PlannedProductionSammMapperTest sammToReportedProduction

2e09cff

jakoballgaier requested a review from ReneSchroederLJ March 13, 2026 12:46

ReneSchroederLJ requested changes Mar 13, 2026

View reviewed changes

fix: PR fixes

d628428

jakoballgaier requested a review from ReneSchroederLJ March 13, 2026 14:07

Merge branch 'feat/anonymized-data-exchange' into feat/planned-produc…

902d498

…tion-anonymized

ReneSchroederLJ requested changes Mar 16, 2026

View reviewed changes

fix: remove log to prevent log injection

1c8c3ba

jakoballgaier requested a review from ReneSchroederLJ March 16, 2026 09:26

ReneSchroederLJ requested changes Mar 18, 2026

View reviewed changes

chore: bump helm chart to 7.0.0 and app version to 6.0.0

f957a25

jakoballgaier requested a review from ReneSchroederLJ March 18, 2026 12:22

chore: move anonymized implementations to 6.0.0

f7d2fad

ReneSchroederLJ merged commit f81e5eb into eclipse-tractusx:feat/anonymized-data-exchange Mar 20, 2026
12 checks passed

	@Operation(summary = "This endpoint receives the Planned Production Submodel 2.0.0 requests. " +
	@Operation(summary = "This endpoint receives the Anonymized Planned Production Submodel 1.0.0 requests. " +

	- Added submodel implementation for planned production output anyonymized ([#1099](https://github.com/eclipse-tractusx/puris/pull/1099))
	- Added submodel implementation for planned production output anonymized ([#1099](https://github.com/eclipse-tractusx/puris/pull/1099))

Conversation

jakoballgaier commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-review checks

Uh oh!

jakoballgaier commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ReneSchroederLJ left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jakoballgaier commented Mar 4, 2026 •

edited

Loading

ReneSchroederLJ left a comment •

edited

Loading

ReneSchroederLJ left a comment •

edited

Loading