Feat/material relations fe#1113
Open
OlgaIvkovic wants to merge 6 commits intoeclipse-tractusx:feat/bill-of-materialsfrom
Open
Feat/material relations fe#1113OlgaIvkovic wants to merge 6 commits intoeclipse-tractusx:feat/bill-of-materialsfrom
OlgaIvkovic wants to merge 6 commits intoeclipse-tractusx:feat/bill-of-materialsfrom
Conversation
ReneSchroederLJ
requested changes
Mar 11, 2026
Member
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
It seems a small error resulted from merging my previous changes. besides that the feature works for the most part just some improvements to validation and styling.
| <Table | ||
| title="Material Relations" | ||
| columns={[ | ||
| { headerName: 'Parent Material Number', field: 'parentMaterialNumber', flex: 1 }, |
Member
There was a problem hiding this comment.
Suggested change
| { headerName: 'Parent Material Number', field: 'parentMaterialNumber', flex: 1 }, | |
| { headerName: 'Parent Material Number', field: 'parentOwnMaterialNumber', flex: 1 }, |
| title="Material Relations" | ||
| columns={[ | ||
| { headerName: 'Parent Material Number', field: 'parentMaterialNumber', flex: 1 }, | ||
| { headerName: 'Child Material Number', field: 'childMaterialNumber', flex: 1 }, |
Member
There was a problem hiding this comment.
Suggested change
| { headerName: 'Child Material Number', field: 'childMaterialNumber', flex: 1 }, | |
| { headerName: 'Child Material Number', field: 'childOwnMaterialNumber', flex: 1 }, |
| flex: 1, | ||
| renderCell: (data: { row: MaterialRelation }) => { | ||
| return ( | ||
| <Box display="flex" textAlign="center" alignItems="center" justifyContent="center" width="100%" height="100%"> |
Member
There was a problem hiding this comment.
Suggested change
| <Box display="flex" textAlign="center" alignItems="center" justifyContent="center" width="100%" height="100%"> | |
| <Box display="flex" textAlign="center" alignItems="center" width="100%" height="100%"> |
| <Box>{new Date(data.row.validFrom).toLocaleDateString('de-DE')}</Box> | ||
| <Box>{new Date(data.row.validFrom).toLocaleTimeString('de-DE')}</Box> | ||
| </Stack> | ||
| ) : null |
Member
There was a problem hiding this comment.
I would show a - if the date is not set how it's usually done elsewhere in the app. Same for valid to.
| flex: 1.5, | ||
| renderCell: (data: { row: MaterialRelation }) => data.row.validFrom ? ( | ||
| <Stack display="flex" textAlign="center" alignItems="center" justifyContent="center" width="100%" height="100%"> | ||
| <Box>{new Date(data.row.validFrom).toLocaleDateString('de-DE')}</Box> |
Member
There was a problem hiding this comment.
Suggested change
| <Box>{new Date(data.row.validFrom).toLocaleDateString('de-DE')}</Box> | |
| <Box>{new Date(data.row.validFrom).toLocaleDateString('en-GB')}</Box> |
| ); | ||
|
|
||
| const validChildMaterials = childBase.filter((mat) => | ||
| !mrs.some((existingMr) => |
| type="number" | ||
| placeholder="Enter quantity" | ||
| value={temporaryMr.quantity ?? ''} | ||
| error={formError && !temporaryMr.quantity} |
Member
There was a problem hiding this comment.
Suggested change
| error={formError && !temporaryMr.quantity} | |
| error={formError && (!temporaryMr.quantity || temporaryMr.quantity <= 0) } |
| error={ | ||
| formError && | ||
| ( | ||
| (!!temporaryMr.validFrom && new Date(temporaryMr.validFrom) > new Date()) || |
Member
There was a problem hiding this comment.
I'm confused by this line. If validFrom is set it can't be after today? There is no such rule for validity that I am aware of.
| error={ | ||
| formError && | ||
| ( | ||
| (!!temporaryMr.validTo && new Date(temporaryMr.validTo) > new Date()) || |
Member
There was a problem hiding this comment.
Same as above. This condition should not exist.
| - name: ENDPOINT_MATERIAL_PARTNER_RELATIONS | ||
| value: "{{ .Values.frontend.puris.endpointMaterialPartnerRelations | default "materialpartnerrelations" }}" | ||
| - name: ENDPOINT_MATERIAL_RELATIONS | ||
| value: "{{ .Values.frontend.puris.endpointMaterialRelations | default "material-relations" }}" |
Member
There was a problem hiding this comment.
You forgot to also add the appropriate new value to the values.yaml file. Also remember to update the readme file accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1086
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)