Feat/data exchange request be by OlgaIvkovic · Pull Request #1116 · eclipse-tractusx/puris

OlgaIvkovic · 2026-03-10T14:34:13Z

Description

added backend implementation for data exchange requests
added a simple bruno test for creating a simple data exchange request

Resolves #1090 .

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files (TRG 7.02
Documentation Notice are present on all affected files (TRG 7.07)
If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
Changelog updated (changelog.md) with PR reference and brief summary.
Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
Backend version bumped, if needed (backend/pom.xml)
Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

ReneSchroederLJ · 2026-03-11T15:10:35Z

I've helped fix some git history issues thus my commit. I did not author the actual content of the commit.

ReneSchroederLJ

Thank you for your contribution. Overall great work. My feedback is mostly down to validations

ReneSchroederLJ · 2026-03-12T09:37:13Z

...pse/tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestController.java

+    @ResponseStatus(HttpStatus.CREATED)
+    public OwnDataExchangeRequest createDataExchangeRequest(@RequestBody OwnDataExchangeRequest ownDataExchangeRequest) {
+        if (!validator.validate(ownDataExchangeRequest).isEmpty()) {
+            throw new ResponseStatusException(HttpStatus.BAD_REQUEST);


Suggested change

throw new ResponseStatusException(HttpStatus.BAD_REQUEST);

throw new ResponseStatusException(HttpStatus.BAD_REQUEST, "Invalid Own Data Exchange Request");

ReneSchroederLJ · 2026-03-12T09:48:11Z

...pse/tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestController.java

+            @ApiResponse(responseCode = "500", description = "Internal Server Error.", content = @Content)
+    })
+    @ResponseStatus(HttpStatus.CREATED)
+    public OwnDataExchangeRequest createDataExchangeRequest(@RequestBody OwnDataExchangeRequest ownDataExchangeRequest) {


It would be better to create a DataExchangeRequestDto that is passed here. The DTO should replace notification with notificationId for simplicity.

ReneSchroederLJ · 2026-03-12T09:48:52Z

...pse/tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestController.java

+        }
+        if (ownDataExchangeRequest.getNotification() == null || ownDataExchangeRequest.getNotification().getNotificationId() == null) {
+            throw new ResponseStatusException(HttpStatus.BAD_REQUEST, "Own Data Exchange Request misses notification identification.");
+        }


This check becomes unnecessary with the DTO change.

ReneSchroederLJ · 2026-03-12T09:52:08Z

...org/eclipse/tractusx/puris/backend/dataexchangerequest/domain/model/DataExchangeRequest.java

+
+    @PrePersist
+    protected void onCreate() {
+        if (timestamp == null) {


This leaves room for timestamp to be manually set. I think it should always overwrite manually set timestamps.

ReneSchroederLJ · 2026-03-12T10:00:39Z

...pse/tractusx/puris/backend/dataexchangerequest/logic/service/DataExchangeRequestService.java

+            errors.add(message);
+        }
+    }
+    private void validateDesiredDate(List<String> errors, Date desiredDate, String fieldName, ReportedDemandAndCapacityNotification notification) {


I think it would make sense to refactor this method to specifically test both dates together, because currently we're lacking the validation dataExchangeRequest.getDesiredStartDate().before(dataExchangeRequest.getDesiredEndDate())

ReneSchroederLJ · 2026-03-12T10:12:42Z

.../tractusx/puris/backend/dataexchangerequest/logic/service/OwnDataExchangeRequestService.java

+    }
+
+    public boolean validate(OwnDataExchangeRequest dataExchangeRequest) {
+        return validateWithDetails(dataExchangeRequest).isEmpty();


At the moment we're providing the elaborate validation feedback messages, but not using them anywhere. The question is will they be used or would a simpler method of validation akin to the one for notifications suffice.

It is arguable that any time an attempt is made to create or update an entity, this kind of detailed feedback is valuable, however we only use detailed feedback for data imports so far.

I will open a separate issue for a potential refactor, but for the time being I suggest converting to returning a simple boolean.

ReneSchroederLJ · 2026-03-12T10:14:41Z

.../tractusx/puris/backend/dataexchangerequest/logic/service/OwnDataExchangeRequestService.java

+    }
+
+    public final OwnDataExchangeRequest create(OwnDataExchangeRequest ownDataExchangeRequest) {
+        if (!validator.apply(ownDataExchangeRequest)) {    


Suggested change

if (!validator.apply(ownDataExchangeRequest)) {

if (ownDataExchangeRequest == null || !validator.apply(ownDataExchangeRequest)) {

ReneSchroederLJ · 2026-03-12T10:22:09Z

...pse/tractusx/puris/backend/dataexchangerequest/logic/service/DataExchangeRequestService.java

+
+        addIfNull(errors, dataExchangeRequest.getCriticality(), "Missing criticality.");
+        addIfNull(errors, dataExchangeRequest.getText(), "Missing text.");
+        addIfNull(errors, dataExchangeRequest.getTimestamp(), "Missing timestamp.");


This validation for timestamp seems problematic to me. On one hand an existing DataExchangeRequest should always have a valid timestamp. However, this check would require manually setting it before the entity is created even though it will automatically be set at creation. My suggestion would be to remove this check or replace it with something like:

(dataExchangeRequest.getUuid() == null || dataExchangeRequest.getTimestamp() != null)

ReneSchroederLJ · 2026-03-12T10:25:42Z

..._01-MAD/01_02-Operational Data/Supplier/DataExchangeRequest/Create Data Exchange Request.bru

+      "n-tier"
+    ],
+    "text": "Please provide the requested data.",
+    "timestamp": "{{DATA_EXCHANGE_TIMESTAMP}}",


As previously discussed timestamp should not be manually set sinc eit will be ignored.

ReneSchroederLJ · 2026-03-12T10:26:31Z

..._01-MAD/01_02-Operational Data/Supplier/DataExchangeRequest/Create Data Exchange Request.bru

+
+script:post-response {
+  console.log("STATUS:", res.getStatus());
+  console.log("BODY:", JSON.stringify(res.getBody(), null, 2));


remove unnecessary scripts

ReneSchroederLJ

Thank you for the changes. I found some further potential improvements. Please also update the version numbers in charts/puris/README.md

ReneSchroederLJ · 2026-03-12T15:05:03Z

...pse/tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestController.java

+            throw new ResponseStatusException(HttpStatus.BAD_REQUEST, "Referenced notification does not exist.");
+        }
+
+        OwnDataExchangeRequest ownDataExchangeRequest = convertToEntity(requestDto);


I'm aware we used to use these kinds of helper methods in the past, but I would opt to use ModelMapper to simplify the process.

This would look something like:

OwnDataExchangeRequest ownDataExchangeRequest = modelMapper.map(requestDto, OwnDataExchangeRequest.class); ownDataExchangeRequest.setNotification(notification);

ReneSchroederLJ · 2026-03-12T15:06:09Z

...pse/tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestController.java

+        ownDataExchangeRequest.setNotification(notification);
+
+        try {
+            return convertToDto(ownDataExchangeRequestService.create(ownDataExchangeRequest));


Same as above. This can be handled with ModelMapper:

OwnDataExchangeRequest newEntity = ownDataExchangeRequestService.create(ownDataExchangeRequest); DataExchangeRequestDto responseDto = modelMapper.map(newEntity, DataExchangeRequestDto.class); responseDto.setNotificationId(notification.getNotificationId()); return responseDto;

ReneSchroederLJ · 2026-03-12T15:08:21Z

...pse/tractusx/puris/backend/dataexchangerequest/logic/service/DataExchangeRequestService.java

+                    dataExchangeRequest.getNotification()
+            );
+    }
+    private boolean validateDesiredDates(Date desiredStartDate, Date desiredEndDate, ReportedDemandAndCapacityNotification notification) {


Since all 3 parameters are properties of OwnDataExchangeRequest I would opt to pass it directly instead of each individual property.

ReneSchroederLJ · 2026-03-12T15:10:22Z

...pse/tractusx/puris/backend/dataexchangerequest/logic/service/DataExchangeRequestService.java

+        if (!desiredStartDate.before(desiredEndDate)) {
+            return false;
+        }
+        if (notification.getStartDateOfEffect() != null) {


This check is not necessary since start date is mandatory for notifications

ReneSchroederLJ · 2026-03-12T15:11:36Z

...tractusx/puris/backend/dataexchangerequest/controller/DataExchangeRequestControllerTest.java

+    }
+
+    @Test
+    void emptyRequest_testValidateWithDetails_returnsValidationErrors() {


fix the function name please due to removal of validateWithDetails

ReneSchroederLJ

I found two very small details to fix. Otherwise good rework.

ReneSchroederLJ · 2026-03-13T12:46:58Z

charts/puris/README.md

 # puris

-![Version: 6.1.0](https://img.shields.io/badge/Version-6.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 5.1.0](https://img.shields.io/badge/AppVersion-5.1.0-informational?style=flat-square)
+![Version: 7.1.0](https://img.shields.io/badge/Version-6.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 6.1.0](https://img.shields.io/badge/AppVersion-5.1.0-informational?style=flat-square)


The versions should be 7.0.0 and 6.0.0. also please update the badge urls accordingly

ReneSchroederLJ · 2026-03-13T12:48:29Z

...pse/tractusx/puris/backend/dataexchangerequest/logic/service/DataExchangeRequestService.java

    }
-    private boolean validateDesiredDates(Date desiredStartDate, Date desiredEndDate, ReportedDemandAndCapacityNotification notification) {
-        if (!desiredStartDate.before(desiredEndDate)) {
+    private boolean validateDesiredDates(DataExchangeRequest ownDataExchangeRequest, ReportedDemandAndCapacityNotification notification) {


Since notification is also a child of dataExchangeRequest it can be omitted from the function parameters as well

OlgaIvkovic requested a review from ReneSchroederLJ March 10, 2026 14:34

OlgaIvkovic force-pushed the feat/data-exchange-request-be branch from 7e117d6 to 52ee4c0 Compare March 11, 2026 14:22

feat: implement be for data exchange request

e126630

ReneSchroederLJ force-pushed the feat/data-exchange-request-be branch from 52ee4c0 to e126630 Compare March 11, 2026 15:09

ReneSchroederLJ linked an issue Mar 12, 2026 that may be closed by this pull request

[Story] Data exchange request backend implementation #1090

Open

ReneSchroederLJ requested changes Mar 12, 2026

View reviewed changes

OlgaIvkovic added 2 commits March 12, 2026 14:25

fix: applied part of pr changes

d7d8512

fix: applied the rest of pr changes

5a1710c

OlgaIvkovic requested a review from ReneSchroederLJ March 12, 2026 14:44

ReneSchroederLJ requested changes Mar 12, 2026

View reviewed changes

fix: apply pr changes

7c8dd7c

OlgaIvkovic requested a review from ReneSchroederLJ March 13, 2026 11:30

ReneSchroederLJ requested changes Mar 13, 2026

View reviewed changes

OlgaIvkovic requested a review from ReneSchroederLJ March 16, 2026 14:33

fix: small pr tweaks

c1dd452

ReneSchroederLJ requested a review from tom-rm-meyer-ISST March 24, 2026 10:48

	throw new ResponseStatusException(HttpStatus.BAD_REQUEST);
	throw new ResponseStatusException(HttpStatus.BAD_REQUEST, "Invalid Own Data Exchange Request");

	if (!validator.apply(ownDataExchangeRequest)) {
	if (ownDataExchangeRequest == null \|\| !validator.apply(ownDataExchangeRequest)) {

Conversation

OlgaIvkovic commented Mar 10, 2026

Description

Pre-review checks

Uh oh!

ReneSchroederLJ commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ReneSchroederLJ commented Mar 11, 2026 •

edited

Loading