Skip to content

Fix for Excel Import #1120

Open
lutoepfer wants to merge 3 commits intoeclipse-tractusx:mainfrom
lutoepfer:fix_import
Open

Fix for Excel Import #1120
lutoepfer wants to merge 3 commits intoeclipse-tractusx:mainfrom
lutoepfer:fix_import

Conversation

@lutoepfer
Copy link
Copy Markdown

@lutoepfer lutoepfer commented Mar 23, 2026

Description

Fixing the Issue #1119

  • introduce business-key based lookup for own productions, deliveries and stocks
  • change delivery business key to use departure and arrival timestamps
  • implement create-or-update (upsert) logic in ExcelService for all imports
  • add tests verifying update paths for demand, production, delivery and stock

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files (TRG 7.02
  • Documentation Notice are present on all affected files (TRG 7.07)
  • Changelog updated (changelog.md) with PR reference and brief summary.

lutoepfer and others added 3 commits March 23, 2026 13:41
…ng rows

- introduce business-key based lookup for own productions, deliveries and stocks
- change delivery business key to use departure and arrival timestamps
- implement create-or-update (upsert) logic in ExcelService for all imports
- add tests verifying update paths for demand, production, delivery and stock
…ng rows

- introduce business-key based lookup for own productions, deliveries and stocks
- change delivery business key to use departure and arrival timestamps
- implement create-or-update (upsert) logic in ExcelService for all imports
- add tests verifying update paths for demand, production, delivery and stock
remove IAV config
@lutoepfer
Copy link
Copy Markdown
Author

Hi,
i have updated the ChangeLog.md, hopefully right.

I run deploy.sh -ci the result you can find here:
local-results.html
local-prepare-existing-assets-results.html

Best Greetings,
Luca

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I think we need some further alignment on the topic, as this pr mixes two things:

  1. it fixes the bug that existing information (duplicates) terminate the import process non-gracefully.
  2. it introduces a feature that not all old information is removed, only duplicates are updated or created

The second point raises the following issues:

  1. The introduced business keys are inconsistent with what is changeable in the frontend (e.g. demand allows to change day, category, quantity in frontend vs. quantity, unit, supplier location, demand location in backend)
  2. The introduced feature changes the import dialog behavior (information is added and changed vs information is removed and added). There is no way of batch removal OR a way to see old data in the application.
  3. The introduced feature creates duplicates (e.g. updating the departure to an actual departure will result in a new departure instead of an update).

From my perspective we should go as follows:

  1. Fix the bug for now with only deleting all information first and then update it. Make the method transactional.
  2. Align on a concept how the import should work (e.g. together with the customer) and consider cross-effects (e.g. right now the change would lead to providing the patner also production information from last year if applied for one year).

I've sent out a link via mail to book an appointment for discussion of the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants