Feature/policy-unit-test#1476
Closed
ds-vlisenco wants to merge 13 commits intoeclipse-tractusx:mainfrom
Closed
Conversation
…eature/policy-unit-test
Added input validation to PolicyServiceImpl#getPolicy to throw IllegalArgumentException when policy ID is null or blank. This ensures consistent error handling and aligns with unit test expectations. Also resolves failing test cases in PolicyServiceImplTest that check for invalid inputs.
Added input validation to PolicyServiceImpl#getPolicy to throw IllegalArgumentException when policy ID is null or blank. This ensures consistent error handling and aligns with unit test expectations. Also resolves failing test cases in PolicyServiceImplTest that check for invalid inputs.
…eature/policy-unit-test
…eature/policy-unit-test
license header is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: Add Unit Tests for the
PolicyServiceImplClassThis PR introduces comprehensive unit tests for the
PolicyServiceImplclass in the Traceability backend. The class contains business logic for managing policies and interacts withPolicyRepositoryandEdcNotificationContractService.The new tests improve code reliability and ensure correct interaction with the dependent components.
Fixes: [add issue number if applicable]
Pre-Review Checks
Please ensure that the following points are completed:
Background
The
PolicyServiceImplclass previously lacked dedicated unit tests. The goal is to ensure its correctness and maintainability through full test coverage of all public methods.Scope
Tested Methods:
getIrsPolicies(): Returns the raw data mapgetPolicies(): Returns a flat list ofPolicyResponsegetPolicy(String id): Success and failure scenarios (PolicyNotFoundException)createPolicy(RegisterPolicyRequest): Creates policy and updates EDCupdatePolicy(UpdatePolicyRequest): Updates policy and updates EDCdeletePolicy(String id): Deletes policy and updates EDCCovered Scenarios:
null, empty values, missing entries)verify)Test Strategy
PolicyServiceImplTest.java@ExtendWith(MockitoExtension.class)assertThrows(...)verify(...)Acceptance Criteria
PolicyServiceImplTest.javacreatedNotes