Feature/remove-notification-controller#1480
Closed
ds-vlisenco wants to merge 35 commits intoeclipse-tractusx:mainfrom
Closed
Feature/remove-notification-controller#1480ds-vlisenco wants to merge 35 commits intoeclipse-tractusx:mainfrom
ds-vlisenco wants to merge 35 commits intoeclipse-tractusx:mainfrom
Conversation
…eature/policy-unit-test
Added input validation to PolicyServiceImpl#getPolicy to throw IllegalArgumentException when policy ID is null or blank. This ensures consistent error handling and aligns with unit test expectations. Also resolves failing test cases in PolicyServiceImplTest that check for invalid inputs.
Added input validation to PolicyServiceImpl#getPolicy to throw IllegalArgumentException when policy ID is null or blank. This ensures consistent error handling and aligns with unit test expectations. Also resolves failing test cases in PolicyServiceImplTest that check for invalid inputs.
…eature/policy-unit-test
feature/policy-unit-test
fix: add null checks to PolicyServiceImpl to handle invalid input
…eature/policy-unit-test
feature/policy-unit-test
Introduced @nested classes to logically group tests by method Added helper method createPolicyResponse to reduce duplication and simplify test setup Fixed usage of PolicyResponse.policyId() to match record syntax (instead of incorrect getPolicyId()) Corrected construction of Payload and IrsPolicyResponse based on their actual constructors Improved test assertions to verify actual field values instead of only presence or size Preserved existing test coverage for all main methods
license header is provided
feature/policy-unit-test license header is provided
feature/digital-twin-part
…neration feature/automate-test-data-generation
…neration feature/automate-test-data-generation
…ation' into feature/automate-test-data-generation
…neration feature/automate-test-data-generation
…neration feature/automate-test-data-generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: remove deprecated EdcNotificationContractController and integration test
This PR removes the no longer used EDC notification contract REST endpoint and its related integration test.
Changes
Deleted obsolete controller:
tx-backend/src/main/java/org/eclipse/tractusx/traceability/notification/application/contract/EdcNotificationContractController.javaDeleted integration test:
tx-backend/src/test/java/org/eclipse/tractusx/traceability/integration/edc/notificationcontract/EdcNotificationContractsControllerIT.javaVerified all test references and endpoint usages (
/api/edc/notification/contract) are removed.Left the
EdcNotificationContractServicein place (still used in internal logic and tests).Retained:
CreateNotificationContractRequestCreateNotificationContractResponseNotes
./mvnw clean verifyRelated
Closes #5 — Remove EdcNotificationContractController API Endpoint
Pre-review checks
/api/edc/notification/contractCHANGELOG.mdupdated under[Unreleased]