Skip to content

feat: add caching with faastapi_cache2 package#173

Open
dddenes wants to merge 2 commits intoeclipse-tractusx:mainfrom
dddenes:caching
Open

feat: add caching with faastapi_cache2 package#173
dddenes wants to merge 2 commits intoeclipse-tractusx:mainfrom
dddenes:caching

Conversation

@dddenes
Copy link

@dddenes dddenes commented Dec 12, 2025

WHAT

Adds a simple in-memory caching solution based on fastapi_cache2 package, with a possible prospect for adding other caching service later on.

WHY

Key-value caching for the Testbed

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes # <-- insert Issue number if one exists

@dddenes dddenes force-pushed the caching branch 3 times, most recently from 282ca93 to e49e37f Compare December 12, 2025 16:33
Copy link
Contributor

@CDiezRodriguez CDiezRodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @dddenes!! Just one thing: could you run poetry lock locally so the three workflows that are currently failing can pass?

@dddenes dddenes force-pushed the caching branch 3 times, most recently from 4e16f80 to 9b1f181 Compare January 6, 2026 18:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

@dddenes
Copy link
Author

dddenes commented Jan 6, 2026

Amazing work @dddenes!! Just one thing: could you run poetry lock locally so the three workflows that are currently failing can pass?

Thanks!

However the package needs a restricted lib, tzdata, is that a problem here? If so, I need to come up with another solution.

@CDiezRodriguez
Copy link
Contributor

CDiezRodriguez commented Jan 12, 2026

Amazing work @dddenes!! Just one thing: could you run poetry lock locally so the three workflows that are currently failing can pass?

Thanks!

However the package needs a restricted lib, tzdata, is that a problem here? If so, I need to come up with another solution.

It is already IP-check open, so we need to wait until this new dependency is approved. Here is the issue:

#################################################################################
# Eclipse Tractus-X - Software Development KIT
#
# Copyright (c) 2025 CGI Deutschland B.V. & Co. KG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care here! You can BMW or Accenture

Comment on lines +24 to +25
## Code originally beloging to Industry Flag Service:
# https://github.com/eclipse-tractusx/tractusx-sdk-services/tree/main/industry-flag-service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this also

@gerbigf gerbigf mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants