init: geometry_aspect_validator#184
init: geometry_aspect_validator#184HannesKrug wants to merge 4 commits intoeclipse-tractusx:mainfrom
Conversation
|
Hello @matbmoser Is there anything that needs changing? |
src/tractusx_sdk/extensions/geometry/geometry_aspect_validator/schemaValidator.py
Show resolved
Hide resolved
|
we have some requirements in the TRGs that need to be followed here so we can merge this PR: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-02
|
|
please also add it to the module |
|
okay thanks for the analysis @matbmoser |
|
@HannesKrug ping me when you have the changes added and I approve and merge it. |
|
the license header you can copy as base one from another file. |
|
@matbmoser adjusted according to your remarks |
|
There was a problem hiding this comment.
Great work, thank you for your changes @HannesKrug @Kapunto !! I want to merge this PR now the released has passed:
Small details your forgot the int.py in the folders look how we do for other extensions:
Maybe the example data you could add to the "/examples" folder, so it does not gets included in the "package" which is built and published to PIPY
We have an /examples folder which you can add the example data and how to run the script: https://github.com/eclipse-tractusx/tractusx-sdk/tree/main/examples/extensions/semantics
OPTIONAL (but maybe interests you):
If you want you can add to our documentation an usage example from your script:
https://eclipse-tractusx.github.io/tractusx-sdk/latest/api-reference/extension-library/
But this is up to you, you would need to add here your specifications (for the geometry model):
https://github.com/eclipse-tractusx/tractusx-sdk/tree/main/docs/api-reference/extension-library
There was a problem hiding this comment.
that is actually part of our poetry project file already.



WHAT
New scripts to validate the new single_level_scene_node from the Geometry Standard.
WHY
Help developers to validate the correct structure of scene_nodes within a digital twin (sub model)
FURTHER NOTES
init
Closes # <-- not specified