Skip to content

init: geometry_aspect_validator#184

Open
HannesKrug wants to merge 4 commits intoeclipse-tractusx:mainfrom
HannesKrug:main
Open

init: geometry_aspect_validator#184
HannesKrug wants to merge 4 commits intoeclipse-tractusx:mainfrom
HannesKrug:main

Conversation

@HannesKrug
Copy link

WHAT

New scripts to validate the new single_level_scene_node from the Geometry Standard.

WHY

Help developers to validate the correct structure of scene_nodes within a digital twin (sub model)

FURTHER NOTES

init

Closes # <-- not specified

@HannesKrug
Copy link
Author

Hello @matbmoser
As discussed in the office hour. Here is a pull request to include the validator scripts into the SDKs.

Is there anything that needs changing?

@matbmoser
Copy link
Contributor

we have some requirements in the TRGs that need to be followed here so we can merge this PR: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-02

  • License headers are missing (you can copy from other modules)
  • Also the license notes in the markdowns need to be added

@matbmoser
Copy link
Contributor

please also add it to the module extensions under a "geometry" folder. like this is more clear, the dataspace module is only for "dataspace interactions with the datasapace shared services and with the edc connector"

@HannesKrug
Copy link
Author

okay thanks for the analysis @matbmoser
ill work that in

@matbmoser
Copy link
Contributor

@HannesKrug ping me when you have the changes added and I approve and merge it.

@matbmoser
Copy link
Contributor

the license header you can copy as base one from another file.

@Kapunto
Copy link

Kapunto commented Mar 4, 2026

@matbmoser adjusted according to your remarks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

@matbmoser matbmoser self-requested a review March 19, 2026 14:22
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for your changes @HannesKrug @Kapunto !! I want to merge this PR now the released has passed:

Small details your forgot the int.py in the folders look how we do for other extensions:

https://github.com/eclipse-tractusx/tractusx-sdk/blob/6eb04f4daf4c23e3a73433cb78e19a9ed7ae4eb6/src/tractusx_sdk/extensions/semantics/__init__.py

Maybe the example data you could add to the "/examples" folder, so it does not gets included in the "package" which is built and published to PIPY

We have an /examples folder which you can add the example data and how to run the script: https://github.com/eclipse-tractusx/tractusx-sdk/tree/main/examples/extensions/semantics

OPTIONAL (but maybe interests you):

If you want you can add to our documentation an usage example from your script:
https://eclipse-tractusx.github.io/tractusx-sdk/latest/api-reference/extension-library/

But this is up to you, you would need to add here your specifications (for the geometry model):
https://github.com/eclipse-tractusx/tractusx-sdk/tree/main/docs/api-reference/extension-library

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is actually part of our poetry project file already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants