WIP: change path to JSON pointer #2168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LukasBoll
force-pushed
the
pathToJSONPointer
branch
from
9a40570 to
c2adb17
Compare
LukasBoll
force-pushed
the
pathToJSONPointer
branch
from
c2adb17 to
63934f5
Compare
sdirix
requested changes
Aug 21, 2023
| const i18nKeyPrefix = getI18nKeyPrefixBySchema(undefined, uischema); | ||
| const i18nKey = | ||
| typeof i18nKeyPrefix === 'string' | ||
| ? `${i18nKeyPrefix}.label` |
There was a problem hiding this comment.
Here we want to keep the dots, right?
packages/core/src/util/path.ts
Outdated
Comment on lines
31
to
42
| let p2 = path2; | ||
| if (!isEmpty(path2) && !path2.startsWith('[') && !path2.startsWith('/')) { | ||
| p2 = '/' + path2; | ||
| } |
There was a problem hiding this comment.
I think we can remove the square brackets handling here. They are not a valid feature of JSON pointers.
packages/core/src/util/path.ts
Outdated
Comment on lines
36
to
39
| if (isEmpty(path1)) { | ||
| return p2; | ||
| } else if (isEmpty(path2)) { | ||
| return p1; | ||
| return path1; |
There was a problem hiding this comment.
Will path2 which is handed in never start with a / already? The compose should have a JSDoc clearly declaring in which format it expects the handed over paths. Looking at this code it seems the path2 is rather a path segment.
LukasBoll
force-pushed
the
pathToJSONPointer
branch
from
63934f5 to
caf7383
Compare
sdirix
requested changes
Aug 29, 2023
sdirix
force-pushed
the
master
branch
2 times, most recently
from
8bd14c2 to
e9946ef
Compare
|
Superseded by rebased and extended PR #2346 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2153