Always call GSTATS in GSTATS_NVTX #230
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain subroutines we overload `GSTATS` with `GSTATS_NVTX` which is intended to collect caliper statistics for Nvidia's NVTX library then call `GSTATS` as usual. The latter was inside an `#if defined(__NVCOMPILER)` which means `GSTATS` was not called for other platforms as it should be. I've moved it outside so `GSTATS` is called as usual for other platforms, like for CCE on LUMI-G.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain subroutines we overload
GSTATSwithGSTATS_NVTXwhich is intended to collect caliper statistics for Nvidia's NVTX library then callGSTATSas usual. The latter was inside an#if defined(__NVCOMPILER)which meansGSTATSwas not called for other platforms as it should be. I've moved it outside soGSTATSis called as usual for other platforms, like for CCE on LUMI-G.