-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/kwargs for zarr open dataset #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EddyCMWF
commented
Dec 3, 2025
- open_dataset -> open_zarr for succinct kwarg passing
- Option for parsing kwargs into open_zarr command
- decrypt kwargs recursivley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but with a couple of comments:
-
I was under the impression that xarray's long-term plan was to deprecate
open_zarr. I cannot see a warning in the documentation though, so I may be wrong. It's no big deal if you are sure that you will always open all ARCO data with zarr-python. -
I would have handled the decryption differently, by explicitly decoding only the credential arguments. The blind recursive decryption seems a bit error prone to me. I am also not a big fan of the
ignore_errorsoption indecrypt. I only added it to comply with the requirements, but I would avoid using it when possible.
|
Thanks @malmans2 , For 2, understood but happy to go with it as it is as the exact credential config is still being discussed and this gives us a nice flexibility. I will open an issue to come back in the future. |
|
Sounds good. open_dataset_kwargs.setdefault("chunks", {}) |
I'll investigate with configs then make default if needed |