Skip to content

Fix setting geography on non-geo field#1022

Merged
sandorkertesz merged 1 commit into
developfrom
feature/set-geography-on-nogeo-field
Jun 16, 2026
Merged

Fix setting geography on non-geo field#1022
sandorkertesz merged 1 commit into
developfrom
feature/set-geography-on-nogeo-field

Conversation

@sandorkertesz

@sandorkertesz sandorkertesz commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR:

  • allow setting the latitudes/longitudes keys on a non-geography field. E.g.:
f_new = f.set({"geography.latitudes": lats, "geography.longitudes": lons})

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.43%. Comparing base (457ce77) to head (36fad1a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1022      +/-   ##
===========================================
+ Coverage    82.41%   82.43%   +0.01%     
===========================================
  Files          237      237              
  Lines        16667    16683      +16     
  Branches       806      806              
===========================================
+ Hits         13736    13752      +16     
  Misses        2694     2694              
  Partials       237      237              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz
sandorkertesz merged commit b78f3f6 into develop Jun 16, 2026
132 of 143 checks passed
@sandorkertesz
sandorkertesz deleted the feature/set-geography-on-nogeo-field branch June 16, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants