Skip to content

Fix/field components - #1029

Merged
sandorkertesz merged 4 commits into
developfrom
fix/field-components
Jun 22, 2026
Merged

Fix/field components#1029
sandorkertesz merged 4 commits into
developfrom
fix/field-components

Conversation

@pawel-wolff

Copy link
Copy Markdown
Contributor

Description

This PR makes a few minor fixes in Field components:

  • ad-hoc registered new type levels: the attribute "positive" is now "" instead of None, which, when used as an attribute in xarray, was breaking serialisation into netcdf
  • xr_engine.coord.LevelCoord uses Field.vertical.cf() instead of creating the same dictionary on the spot that is feeding the coordinate attributes (it is a code refactoring in a sense, not a behaviour change)
  • fix of a simple refactoring bug in the Field.proc component

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.43%. Comparing base (a0d6492) to head (5b95afb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1029   +/-   ##
========================================
  Coverage    82.43%   82.43%           
========================================
  Files          237      237           
  Lines        16683    16683           
  Branches       806      806           
========================================
  Hits         13752    13752           
  Misses        2694     2694           
  Partials       237      237           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz
sandorkertesz merged commit a571e4b into develop Jun 22, 2026
142 of 143 checks passed
@sandorkertesz
sandorkertesz deleted the fix/field-components branch June 22, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants