feat: add overloads for file, file-pattern and url for from_source#1035
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1035 +/- ##
========================================
Coverage 82.44% 82.44%
========================================
Files 237 237
Lines 16698 16698
Branches 808 808
========================================
Hits 13767 13767
Misses 2694 2694
Partials 237 237 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Oisin-M
marked this pull request as ready for review
June 24, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Edit: done for all sources now. Should maybe move to
.pyifiles later.Adds overloads to
from_sourceso that one gets suggestions, type hints etc. when using the methods. Related to #989.I've added this as a proof-of-concept for 3 sources using the docs here, gives the following suggestions:

Docs to be checked, but doesn't seem to link to autogenerated docs so I think we're fine there.
Contributor Declaration
By opening this pull request, I affirm the following: