Skip to content

feat: add overloads for file, file-pattern and url for from_source#1035

Merged
sandorkertesz merged 5 commits into
developfrom
feat/overload_from_source
Jun 24, 2026
Merged

feat: add overloads for file, file-pattern and url for from_source#1035
sandorkertesz merged 5 commits into
developfrom
feat/overload_from_source

Conversation

@Oisin-M

@Oisin-M Oisin-M commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Edit: done for all sources now. Should maybe move to .pyi files later.

Adds overloads to from_source so that one gets suggestions, type hints etc. when using the methods. Related to #989.

I've added this as a proof-of-concept for 3 sources using the docs here, gives the following suggestions:
Screenshot 2026-06-24 at 12 15 19

Docs to be checked, but doesn't seem to link to autogenerated docs so I think we're fine there.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.44%. Comparing base (4633b7e) to head (ab280f8).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1035   +/-   ##
========================================
  Coverage    82.44%   82.44%           
========================================
  Files          237      237           
  Lines        16698    16698           
  Branches       808      808           
========================================
  Hits         13767    13767           
  Misses        2694     2694           
  Partials       237      237           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Oisin-M
Oisin-M marked this pull request as ready for review June 24, 2026 12:07
@sandorkertesz
sandorkertesz merged commit ffe0e1f into develop Jun 24, 2026
115 of 116 checks passed
@sandorkertesz
sandorkertesz deleted the feat/overload_from_source branch June 24, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants