Skip to content

Fix to_xarray kwargs for netcdf data object#1048

Merged
sandorkertesz merged 3 commits into
mainfrom
feature/pass-kwargs-to-netcdf-reader
Jun 30, 2026
Merged

Fix to_xarray kwargs for netcdf data object#1048
sandorkertesz merged 3 commits into
mainfrom
feature/pass-kwargs-to-netcdf-reader

Conversation

@sandorkertesz

@sandorkertesz sandorkertesz commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR:

  • fixed the issue when the NetCDFData.to_xarray() method did not pass xarray_open_mfdataset_kwargs to the underlying reader.
  • It also improved the docstring and tests of NetCDFData.to_xarray()

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 17.94872% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.29%. Comparing base (2a8a183) to head (510c6e9).

Files with missing lines Patch % Lines
tests/netcdf/test_netcdf_convert.py 17.94% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   82.44%   82.29%   -0.16%     
==========================================
  Files         237      237              
  Lines       16757    16794      +37     
  Branches      818      818              
==========================================
+ Hits        13816    13821       +5     
- Misses       2698     2730      +32     
  Partials      243      243              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz
sandorkertesz merged commit 3b87357 into main Jun 30, 2026
141 checks passed
@sandorkertesz
sandorkertesz deleted the feature/pass-kwargs-to-netcdf-reader branch June 30, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants