Skip to content

Feature/xarray to grib from temporal accumulation - #735

Closed
sandorkertesz wants to merge 34 commits into
mainfrom
feature/xarray-to-grib-from-temporal-accumulation
Closed

Feature/xarray to grib from temporal accumulation#735
sandorkertesz wants to merge 34 commits into
mainfrom
feature/xarray-to-grib-from-temporal-accumulation

Conversation

@sandorkertesz

Copy link
Copy Markdown
Collaborator

No description provided.

@sandorkertesz

Copy link
Copy Markdown
Collaborator Author

This PR fixes the following Xarray to GRIB conversion issue.

Generate the data:

  • GRIB forecast data containing step ranges converted to Xarray with time_dim_mode="valid_time"
  • the Xarray is converted back to GRIB

Problems:

  • the generated GRIB contains an inconsistent time section: dataData/Time + step != validityData/Time
  • as a consequence, when the GRIB is converted to Xarray with time_dim_mode="valid_time" there is a crash: "ValueError: Input does not form a full hypercube. Expected number of fields based on the dimensions does not match actual number of fields"

@codecov-commenter

codecov-commenter commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.74%. Comparing base (66cddef) to head (135eff3).
⚠️ Report is 135 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   90.02%   85.74%   -4.29%     
==========================================
  Files         158      172      +14     
  Lines       12086    13242    +1156     
  Branches      593      643      +50     
==========================================
+ Hits        10881    11354     +473     
- Misses       1023     1698     +675     
- Partials      182      190       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sandorkertesz and others added 28 commits July 28, 2025 10:19
Merge main into develop
Use correct environment variable name in doc
* Add conversion to geojson ffrom covjson to covjsonreader, add test, update minimum covjsonkit version
@sandorkertesz
sandorkertesz force-pushed the feature/xarray-to-grib-from-temporal-accumulation branch from 135eff3 to 3cbe8df Compare September 9, 2025 10:11
@sandorkertesz
sandorkertesz deleted the feature/xarray-to-grib-from-temporal-accumulation branch September 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants