Skip to content

Fix for the issue #786: inconsistent behaviour of global_attrs in to_xarray - #787

Merged
sandorkertesz merged 1 commit into
mainfrom
fix/xr-engine-global-attrs
Aug 26, 2025
Merged

Fix for the issue #786: inconsistent behaviour of global_attrs in to_xarray#787
sandorkertesz merged 1 commit into
mainfrom
fix/xr-engine-global-attrs

Conversation

@pawel-wolff

Copy link
Copy Markdown
Contributor

Description

Fixes the issue #786.

A relevant test added.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.66%. Comparing base (66cddef) to head (e8efbb4).
⚠️ Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   90.02%   85.66%   -4.36%     
==========================================
  Files         158      172      +14     
  Lines       12086    13175    +1089     
  Branches      593      637      +44     
==========================================
+ Hits        10881    11287     +406     
- Misses       1023     1698     +675     
- Partials      182      190       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz
sandorkertesz merged commit 2686548 into main Aug 26, 2025
128 of 132 checks passed
@sandorkertesz
sandorkertesz deleted the fix/xr-engine-global-attrs branch August 26, 2025 13:20
@sandorkertesz

Copy link
Copy Markdown
Collaborator

@pawel-wolff, thanks for fixing it! Version 0.16.2 has been released containing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants