Skip to content

Add conversion to geojson from covjson to covjsonreader - #794

Merged
sandorkertesz merged 5 commits into
developfrom
feature/covjson_to_geojson
Aug 29, 2025
Merged

Add conversion to geojson from covjson to covjsonreader#794
sandorkertesz merged 5 commits into
developfrom
feature/covjson_to_geojson

Conversation

@awarde96

Copy link
Copy Markdown
Contributor

Description

Covjsonkit 0.2.2 now supports conversion of coveragejson to geojson. To allow this to be used via earthkit-data the GeojsonMixIn has been added to the Covjsonreader.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

codecov-commenter commented Aug 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (d3c5b57) to head (dcf153e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #794   +/-   ##
========================================
  Coverage    85.68%   85.68%           
========================================
  Files          172      172           
  Lines        13185    13191    +6     
  Branches       637      637           
========================================
+ Hits         11297    11303    +6     
  Misses        1698     1698           
  Partials       190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@awarde96
awarde96 requested a review from sandorkertesz August 29, 2025 08:55
@sandorkertesz

Copy link
Copy Markdown
Collaborator

@awarde96, many thanks for this development.

Please can you update the covjsonkit version also in environment.yaml and tests/environment-unit-tests.yml?

@awarde96

Copy link
Copy Markdown
Contributor Author

I think both should be updated now

@sandorkertesz

Copy link
Copy Markdown
Collaborator

pyproject.toml should be updated too

@awarde96

Copy link
Copy Markdown
Contributor Author

Done now

@sandorkertesz
sandorkertesz merged commit 4ac028d into develop Aug 29, 2025
131 checks passed
@sandorkertesz
sandorkertesz deleted the feature/covjson_to_geojson branch August 29, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants