Add conversion to geojson from covjson to covjsonreader - #794
Merged
Conversation
…pdate minimum covjsonkit version
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #794 +/- ##
========================================
Coverage 85.68% 85.68%
========================================
Files 172 172
Lines 13185 13191 +6
Branches 637 637
========================================
+ Hits 11297 11303 +6
Misses 1698 1698
Partials 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@awarde96, many thanks for this development. Please can you update the covjsonkit version also in environment.yaml and tests/environment-unit-tests.yml? |
Contributor
Author
|
I think both should be updated now |
Collaborator
|
pyproject.toml should be updated too |
Contributor
Author
|
Done now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Covjsonkit
0.2.2now supports conversion of coveragejson to geojson. To allow this to be used via earthkit-data theGeojsonMixInhas been added to the Covjsonreader.Contributor Declaration
By opening this pull request, I affirm the following: