Fix xarray to grib from temporal accumulation - #799
Merged
sandorkertesz merged 6 commits intoSep 9, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #799 +/- ##
===========================================
+ Coverage 85.68% 85.72% +0.03%
===========================================
Files 172 172
Lines 13193 13222 +29
Branches 637 640 +3
===========================================
+ Hits 11305 11334 +29
Misses 1698 1698
Partials 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandorkertesz
deleted the
feature/xarray-to-grib-from-temporal-accumulation
branch
September 9, 2025 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue when Xarray generated from GRIB data containing temporal accumulation was not correctly written back to GRIB.
The problem can be demonstrated with this code:
It produces a GRIB file with incorrect time. E.g. in message 20 we see:
Contributor Declaration
By opening this pull request, I affirm the following: