CodesHandle::getBytes: use length instead of size to determine array size #129
+153
−269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes getting
CodesHandle::getBytesinmetkit/codes/api/CodesAPI.cc.The way how the number of bytes is determined has been unclear and differs from the way arrays are retrieved.
Although bytes are returned as an array, they are handled similar to string and hence have there size described through the
codes_get_lengthcall instead ofcodes_get_size.The highlevel API takes care of these subtle differences. One usecase of the problem has been in the GRIBDecoder where
uuidOfHGridwas accessed.See related issue: https://jira.ecmwf.int/browse/ECC-2166
Contributor Declaration
By opening this pull request, I affirm the following: