fix: Trailing slash for missing path#148
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts URL construction for the generate-version-selector helper script so that the Sites API URL includes a trailing slash when the --path input is empty, matching the API’s expected format for listing at the root.
Changes:
- Append a trailing
/toAPI_URLwhenargs.pathis falsy (e.g., empty string), so root-path listing hits.../files/instead of.../files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tbkr
force-pushed
the
hotfix/version_gen_no_path
branch
from
4256ec0 to
ac2d687
Compare
tbkr
force-pushed
the
hotfix/version_gen_no_path
branch
from
ac2d687 to
b9fdce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trailing slash for missing path
Contributor Declaration
By opening this pull request, I affirm the following: