Ensure file streams are closed after use

ecoAPM · Dec 2, 2022 · 03a56e7 · 03a56e7
1 parent db9f949
commit 03a56e7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/LibYear.Core/LibYear.Core.csproj b/src/LibYear.Core/LibYear.Core.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<Version>7.0.0</Version>
+		<Version>7.0.1</Version>
 		<TargetFramework>net6.0</TargetFramework>
 		<Product>libyear</Product>
 		<PackageId>LibYear.Core</PackageId>

diff --git a/src/LibYear.Core/ProjectFileManager.cs b/src/LibYear.Core/ProjectFileManager.cs
@@ -1,4 +1,5 @@
 using System.IO.Abstractions;
+using System.Text;
 using LibYear.Core.FileTypes;
 
 namespace LibYear.Core;
@@ -61,6 +62,8 @@ private async Task<IProjectFile> ReadFile(IFileSystemInfo fileInfo)
 		var path = fileInfo.FullName;
 		var stream = _fileSystem.FileStream.New(path, FileMode.Open, FileAccess.Read, FileShare.Read);
 		var contents = await new StreamReader(stream).ReadToEndAsync();
+		stream.Close();
+
 		if (IsCsProjFile(fileInfo))
 			return new CsProjFile(path, contents);
 		if (IsDirectoryBuildPropsFile(fileInfo))
@@ -82,6 +85,7 @@ public async Task<IReadOnlyCollection<string>> Update(SolutionResult result)
 
 			var stream = _fileSystem.FileStream.New(project.ProjectFile.FileName, FileMode.OpenOrCreate, FileAccess.Write, FileShare.None);
 			await new StreamWriter(stream).WriteAsync(update);
+			stream.Close();
 			updated.Add(project.ProjectFile.FileName);
 		}
 

diff --git a/src/LibYear/LibYear.csproj b/src/LibYear/LibYear.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<Version>7.0.0</Version>
+		<Version>7.0.1</Version>
 		<OutputType>Exe</OutputType>
 		<PackAsTool>true</PackAsTool>
 		<Product>libyear</Product>