Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a path is rebuilt with fewer commands, its backing buffer may retain the previous tail.
appendPath()allocates space from the source's logical length but currently copies the whole buffer, so merging a shrunken path can include stale geometry or write past a typed destination's capacity.Copy only the logical length of each source, preserving existing destination data and leaving source buffers unchanged. Add regression coverage for Array/Float32Array combinations, empty and multiple sources, and the public
mergePath()bounding rectangle after a polyline shrinks.Validation: 79 unit tests across 13 suites and
npm run lintpass on Node 18.20.8. The 11 added tests fail 9/11 before the fix and pass 11/11 after it. On Windows, the test command supplies the same test glob with forward slashes to avoid Jest 27 normalizing the.agent-storageparent incorrectly.npm ci's prepare step andnpm run releaseare blocked by the pre-existing TS2683 error atsrc/canvas/Painter.ts:1254(this.dprinside a callback); this also occurred before the production change, and that file is unchanged.Fixes #1168.