Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWC compiles TypeScript one file at a time. The public export barrel currently mixes value exports with type-only exports, which makes SWC emit a runtime re-export for
PointLike. Node then rejects the barrel becausePointLikeis an interface.Use explicit
export typedeclarations for the type-only exports and enable TypeScript'sisolatedModulescheck to catch future instances. The published declaration API and the existing runtime bindings are preserved.Fixes #1094.
Verification
npm run checktype -- --pretty falseandnpm run lintnpm test -- --runInBandpassed all 68 testsnpm run build:libandnpm run releasePointLike.AI assistance was used in preparing this change and running the checks.