[15.0][FIX] budget_control_request_document_expense: uncommit RQ before submit EX#544
Merged
Pani-k-folk merged 1 commit into15.0from Jan 23, 2026
Conversation
Pani-k-folk
changed the title
Pani-k-folk
changed the title
Saran440
reviewed
Jan 23, 2026
Collaborator
Saran440
left a comment
Saran440
left a comment
There was a problem hiding this comment.
- อธิบาย step to error หน่อยนะครับ เผื่อกลับมาอ่านอีกทีจะได้เข้าใจว่าแก้จากเคสไหน
- เห็นมีเพิ่ม
self.env.context.get("check_budget_precommit", False)ส่วนนี้จะไม่กระทบกับกรณีปกติใช่ไหม เช่น- expense ไม่ได้ config ให้ auto state post เมื่อ RQ จองงบประมาณแล้ว ถ้ากด recompute จะยังจองถูกต้องไหม
- expense ไม่ได้ config ให้ auto state post เมื่อ RQ ผ่านการอนุมัติแล้ว ระบบจะสร้าง expense = draft แล้วกด submit ระบบจะ check budget ถูกต้องไหม
budget_control_request_document_expense/models/request_document.py
Outdated
Show resolved
Hide resolved
Pani-k-folk
force-pushed
the
15.0-fix-budget_control_request_document_expense-check_budget_precommit
branch
from
5b0d984 to
5232ffc
Compare
Author
|
/ocabot merge patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
แก้ไขระบบให้ uncommit request ก่อน precommit ex
STEP TO ERROR
สาเหตุเกิดจาก
การแก้ไข