Skip to content

Improve APY dashboard table accessibility#584

Open
donglrd wants to merge 1 commit into
edehvictor:mainfrom
donglrd:improve-apy-dashboard-a11y
Open

Improve APY dashboard table accessibility#584
donglrd wants to merge 1 commit into
edehvictor:mainfrom
donglrd:improve-apy-dashboard-a11y

Conversation

@donglrd

@donglrd donglrd commented May 28, 2026

Copy link
Copy Markdown

Summary:

  • Adds accessible table sort buttons with aria-sort, aria-pressed, and descriptive labels.
  • Makes risk tooltip and stale APY status easier to use with assistive tech.
  • Respects reduced-motion preference for dashboard entry and row animations.
  • Adds a regression test for the table accessibility behavior.

Testing:

  • npm test -- --run src/components/dashboard/tests/ApyDashboard.test.tsx
  • npx eslint src/components/dashboard/ApyDashboard.tsx src/components/dashboard/tests/ApyDashboard.test.tsx

Notes:

  • npm run lint and npm run build are currently blocked by existing unrelated lint/type errors elsewhere in the client.

Fixes #542

@vercel

vercel Bot commented May 28, 2026

Copy link
Copy Markdown

@donglrd is attempting to deploy a commit to the Edeh Victor's projects Team on Vercel.

A member of the Team first needs to authorize it.

@donglrd donglrd force-pushed the improve-apy-dashboard-a11y branch from 0a2c9fa to 2657ad9 Compare June 2, 2026 03:20
@edehvictor

Copy link
Copy Markdown
Owner

@donglrd Kindly resolve conflict

@edehvictor

Copy link
Copy Markdown
Owner

@donglrd Kindly resolve conficts

@donglrd donglrd force-pushed the improve-apy-dashboard-a11y branch from 2657ad9 to 2e59033 Compare June 5, 2026 01:27
@donglrd donglrd force-pushed the improve-apy-dashboard-a11y branch from 2e59033 to 2e2fe1e Compare June 5, 2026 01:27
@donglrd

donglrd commented Jun 5, 2026

Copy link
Copy Markdown
Author

Rebased on the latest main and resolved the dashboard conflicts.

Validated locally with:

  • npx prettier --write src/components/dashboard/ApyDashboard.tsx src/components/dashboard/__tests__/ApyDashboard.test.tsx
  • npm test -- --run src/components/dashboard/__tests__/ApyDashboard.test.tsx
  • npx eslint src/components/dashboard/ApyDashboard.tsx src/components/dashboard/__tests__/ApyDashboard.test.tsx
  • git diff --check

@github-actions

Copy link
Copy Markdown

This pull request has been inactive for 21 days and will be marked as stale.

To keep it active:

  • Add a comment with updates or questions
  • Address any pending review comments
  • Add the keep-active label to prevent auto-closure

If no activity occurs in 7 days, this PR will be automatically closed.

Thank you for contributing to StellarYield! 🚀

@github-actions github-actions Bot added the stale label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve APY Dashboard Table Accessibility

2 participants