test(optimistic-governance): add challenge-window boundary and storage cleanup tests#882
Merged
edehvictor merged 1 commit intoJun 27, 2026
Conversation
…e cleanup tests Closes edehvictor#875 Closes edehvictor#874 Closes edehvictor#873 Closes edehvictor#872
|
@Chucks1093 is attempting to deploy a commit to the Edeh Victor's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chucks1093 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #875
Closes #874
Closes #873
Closes #872
What was done
Added deterministic test coverage for the
optimistic_governancecontract's challenge-window boundary behaviour and post-resolution storage state (issue #875).Challenge-window boundary tests
test_execute_at_exact_boundary— confirms execution is accepted whentimestamp == execution_time(inclusive lower bound).test_execute_one_second_before_boundary_fails— verifiesChallengeWindowActiveis returned whentimestamp == execution_time - 1.test_dispute_at_last_second_inside_window— confirms a dispute submitted atexecution_time - 1is accepted.test_dispute_at_exact_boundary_fails— verifiesChallengeWindowExpiredis returned whentimestamp == execution_time.Post-resolution storage cleanup tests
test_proposal_record_persists_after_execution— the proposal record remains readable withExecutedstatus after execution; nothing is deleted.test_double_execute_fails— re-executing an already-executed proposal is correctly rejected.test_expired_uncleared_proposal_still_executable— a proposal that has been pending long past its execution time (no phantom cleanup) can still be executed deterministically.