Merged
Conversation
jmxnzo
force-pushed
the
transitapi/tls-authentication
branch
from
a6c588c to
e19c325
Compare
burgerdev
reviewed
Apr 9, 2025
Member
burgerdev
left a comment
burgerdev
left a comment
There was a problem hiding this comment.
Please squash the commits - at least the first one is partially reverted by the last one.
jmxnzo
force-pushed
the
transitapi/loggingMiddleware
branch
from
411b59f to
1ce833c
Compare
jmxnzo
force-pushed
the
transitapi/tls-authentication
branch
from
7d585df to
b5249b5
Compare
burgerdev
approved these changes
Apr 9, 2025
Adds the required auth logic to the transit engine API to accomplish the client authentication of the mTLS handshake. A client can be authenticated based on a valid mesh cert issued by the mesh CA of the current state. authority: prepare meshCAPool + getter transitapi: use getMeshCACertPool getMeshCACertPool uses cert pool, containing the mesh CA certificate, which is prepared when constructing the CA, to avoid reparsing the certs.
jmxnzo
force-pushed
the
transitapi/tls-authentication
branch
from
b5249b5 to
a1eaded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the required auth logic to the transit engine API to accomplish the client authentication of the mTLS handshake. A client can be authenticated based on a valid mesh cert issued by the mesh CA of the current state.