Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump sdk version to 3.1.1 #498

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

FelixTing
Copy link
Member

fix: #497

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

@@ -1 +1 @@
3.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 3.1.1 and not 3.1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I see that this is in prep for the future version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, we missed the version number change step in v3.1.0, and we wrote the known bug on wiki:
https://wiki.edgexfoundry.org/pages/viewpage.action?pageId=88212172#Napa(NextRelease)-KnownBugs
it only implacts the logs, and it should be a blocker for release
it's the last one we need to manually change the version number.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only implacts the logs, and it should be a blocker for release

@cloudxxx8 , I assume you mean "it should not be a blocker for release", which I agree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, should not

Copy link

@lindseysimple lindseysimple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindseysimple lindseysimple merged commit 80ac549 into edgexfoundry:napa Jun 3, 2024
3 checks passed
@FelixTing FelixTing deleted the issue-497 branch June 3, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants