Repository navigation
fix(workflow): run No Mistakes only in initialized repos - #62
Merged
Merged
Conversation
- Check the no-mistakes remote before do-commit, do-it, and the PR workflow - A repo that never ran init publishes the normal way
…stakes is unavailable
…nd remove stale copies
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Reviewed the enrollment-based publication instructions and matching documentation across all nine changed files; validation was source inspection, not live agent execution.
- Enrollment routing:
do-commitanddo-git-safe-pr-workflowrequire repository enrollment, not merely an installed binary, before invoking No Mistakes. - Blocked publication: Enrolled repositories stop when the binary or gate is unavailable, and
do-itpropagates the blocked result; unenrolled repositories publish normally without initialization prompts. - Documentation: README and workflow pages reflect the routing, and the duplicated research draft now links to current guidance.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Intent
The user reviewed the global No Mistakes policy and decided it is not a requirement of every project. The do-* skills that invoke No Mistakes must check whether this repo was already initialized before running it. If the no-mistakes remote exists (or no-mistakes axi shows this repo), run the gate. If not, do not run it, do not ask, do not run no-mistakes init, and publish the normal way.
The binary being installed is not enough. This covers do-commit, do-git-safe-pr-workflow, do-it, and the docs that describe them (README ship table, commit.md, git-safe-pr-workflow.md, it.md).
The user then asked to run cpp and land this change on master. todo.txt was left uncommitted because it conflicts with an unrelated stack (docs/doskills-cutover-status) that already owns that file.
What Changed
do-commit,do-git-safe-pr-workflow, anddo-itonly when the repo is already initialized, as identified by its remote or axi.Risk Assessment
✅ Low: The bounded instruction changes satisfy the opt-in policy and close the prior missing-binary bypass consistently across the affected workflows and documentation.
Testing
Completed read-only change and execution-surface inspection after GitButler failed. No executable policy tests or rendered UI checks applied; no live behavior or visual evidence was produced.
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
skills/global/workflow/do-commit/references/procedure.md:19- The intent requires: "If the no-mistakes remote exists (or no-mistakes axi shows this repo), run the gate." In an initialized repo where the binary is unavailable on PATH, the combined check fails and the new instruction, "If the check fails, skip this section and publish withbut pushorgit push," explicitly bypasses the gate. The same fallback appears at skills/global/workflow/do-git-safe-pr-workflow/SKILL.md:40 for publication and PR operations; skills/global/workflow/do-commit/SKILL.md:29 covers cp/cpp/land, and skills/global/workflow/do-it/SKILL.md:25 delegates cpp to it. Separate enrollment from tool availability: allow normal publication only when the repo is unenrolled, and report a blocker when an enrolled repo cannot run the gate. Remove the missing-binary fallback case; it exceeds the authorized opt-out.🔧 Fix applied.
✅ Re-checked - no issues remain.
but diff 8cfdf69e196b1de9dfa7d07b1d05c5a3a81274beattempted; GitButler rejected the worktree as a bare repository.git diff --stat 8cfdf69e196b1de9dfa7d07b1d05c5a3a81274be 79fea519b2488ca588bbd105ef52e12e96a95687Read-only diff and manual inspection of all eight changed Markdown files against the authoritative intent and R1 decision.git rev-parse HEADandgit diff --stat 79fea519b2488ca588bbd105ef52e12e96a95687confirmed the supplied target with no local changes.Inspected the site entry points to distinguish documentation rendering from policy execution.🔧 No changes applied.
2 warnings still open:
but show 79fea519b2488ca588bbd105ef52e12e96a95687— unavailable because GitButler rejects the gate repository as bare.git diff 8cfdf69e196b1de9dfa7d07b1d05c5a3a81274be 79fea519b2488ca588bbd105ef52e12e96a95687— read-only inspection of all changed instructions and documentation.Inspected.agents,scripts,.github, and site configuration for an executable policy consumer.git status --short— confirmed no testing changes remained.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.