Skip to content

Commit

Permalink
Bump CMake min requirement to 3.16.3 everywhere (#57)
Browse files Browse the repository at this point in the history
To keep them aligned with the main CMakeLists.txt file.

Seems to be the cause of editorconfig/editorconfig-core-py#51, since CMake warned about dropping compatibility below 3.10 a few versions ago.
  • Loading branch information
xuhdev authored Dec 12, 2024
1 parent 397141d commit d91029b
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmake/almostcat.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.16.3)

if("${WHICH}" STREQUAL "")
message(FATAL_ERROR "No WHICH parameter specified")
Expand Down
2 changes: 1 addition & 1 deletion cmake/ec_sort.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.16.3)

# See documentation links at https://stackoverflow.com/q/12802377/2877364
set(tests_cmake_ec_sort_dir "${CMAKE_CURRENT_LIST_DIR}")
Expand Down
2 changes: 1 addition & 1 deletion cmake/runandsort.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.16.3)

# Conventions:
# - "P_*" are parameters parsed using cmake_parse_arguments
Expand Down
2 changes: 0 additions & 2 deletions filetree/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
# POSSIBILITY OF SUCH DAMAGE.
#

cmake_minimum_required(VERSION 3.5)

# Test for EditorConfig file in parent directory
new_ec_test(parent_directory parent_directory.in parent_directory/test.a "^key=value[ \t\n\r]*$")

Expand Down
2 changes: 0 additions & 2 deletions meta/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

cmake_minimum_required(VERSION 3.5)

set(tests_meta_cmakelists_dir "${CMAKE_CURRENT_LIST_DIR}")

# Line separator regex, for convenience
Expand Down

0 comments on commit d91029b

Please sign in to comment.