Skip to content

Commit

Permalink
ci(workflows): update (#373)
Browse files Browse the repository at this point in the history
* ci(workflows): update actions

* ci(workflows/test): cache vscode installation

* remove redunant env vars

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables

* chore(pr template): `npm run compile` -> `npm run build`

* Revert "ci(workflows/test): cache vscode installation"

This reverts commit 0294aa5.
Don't remember why I was thinking that this significtly reduces workflow execution time, but now I cheked it and it doesn't.
  • Loading branch information
SunsetTechuila authored Jan 30, 2025
1 parent 61547eb commit 67fb170
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
3 changes: 1 addition & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ Please fill in this template.

- [ ] Use a meaningful title for the pull request.
- [ ] Use meaningful commit messages.
- [ ] Run `tsc` w/o errors (same as `npm run compile`).
- [ ] Run `tsc` w/o errors (same as `npm run build`).
- [ ] Run `npm run lint` w/o errors.

8 changes: 3 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: 16
node-version: lts/*
- name: Install
env:
CI: true
run: npm ci
- name: Create Changelog
run: |
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ jobs:
- name: Preserve line endings
run: git config --global core.autocrlf false
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Start xvfb
Expand All @@ -41,5 +41,4 @@ jobs:
npm ci
npm test
env:
CI: true
DISPLAY: ":99.0"

0 comments on commit 67fb170

Please sign in to comment.