Skip to content

Commit

Permalink
Remove node 18 from CI (#394)
Browse files Browse the repository at this point in the history
* Remove node 18 Support

Seems like the latest VSCode doesn't support Node 18 any more.

* use latest lts node in ci

* Add comments

---------

Co-authored-by: Grigory <[email protected]>
  • Loading branch information
xuhdev and SunsetTechuila authored Feb 8, 2025
1 parent 033478c commit ec849f9
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,12 @@ on:

jobs:
test:
name: Test on node ${{ matrix.node }} and ${{ matrix.os }}
name: Test on ${{ matrix.os }}

runs-on: ${{ matrix.os }}

strategy:
matrix:
node: [18, 20, 22]
os:
- ubuntu-latest
- windows-latest
Expand All @@ -30,7 +29,14 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
# In CI, this Node is only used to
# - Install dependencies,
# - Run tools like typescript and eslint
# - Execute the runTests function of the @vscode/test-electron package
#
# Therefore, it doesn't have to match the Node version supported by
# VSCode.
node-version: lts/*
- name: Start xvfb
run: |
/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
Expand Down
7 changes: 7 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"git-submodules": {
"enabled": true
},
"packageRules": [
{
"description": "Use types of the minimum supported Node version",
"matchPackageNames": ["@types/node"],
"allowedVersions": "=18"
}
],
"schedule": ["on Wednesday"]
}

0 comments on commit ec849f9

Please sign in to comment.