Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 18 from CI #394

Merged
merged 3 commits into from
Feb 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,12 @@ on:

jobs:
test:
name: Test on node ${{ matrix.node }} and ${{ matrix.os }}
name: Test on ${{ matrix.os }}

runs-on: ${{ matrix.os }}

strategy:
matrix:
node: [18, 20, 22]
os:
- ubuntu-latest
- windows-latest
Expand All @@ -30,7 +29,14 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
# In CI, this Node is only used to
# - Install dependencies,
# - Run tools like typescript and eslint
# - Execute the runTests function of the @vscode/test-electron package
#
# Therefore, it doesn't have to match the Node version supported by
# VSCode.
node-version: lts/*
- name: Start xvfb
run: |
/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
Expand Down
7 changes: 7 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"git-submodules": {
"enabled": true
},
"packageRules": [
{
"description": "Use types of the minimum supported Node version",
"matchPackageNames": ["@types/node"],
"allowedVersions": "=18"
}
],
"schedule": ["on Wednesday"]
}