fix: restore selections *after* the file save #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the problem with the #372 is that it doesn't pause the event loop to apply changes, which works only with autosave enabled and #386 doesn't fix any "race condition", it just gives more time to re-save the file |
SunsetTechuila
commented
Feb 8, 2025
| @@ -64,6 +65,11 @@ export default class DocumentWatcher { | |||
|
|
|||
| subscriptions.push( | |||
| workspace.onDidSaveTextDocument(doc => { | |||
| const activeEditor = window.activeTextEditor | |||
There was a problem hiding this comment.
it is technically possible that it can be changed during saving, but this is very unlikely
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
tscw/o errors (same asnpm run build).npm run lintw/o errors.fixes #396