Increase the height of the code boxes, make textarea vertically resizable

[kirjs]

See the screenshot below

[treyhunner]

@kcherkashin thanks for the pull request. The textareas are supposed to resize automatically as they do in Chrome. I just noticed that this behavior is broken in Firefox. I'd like to reproduce the expected behavior instead of introduce new behavior.

Also note that the style.scss file is unminified/preprocessed so I couldn't view your version at http://kcherkashin.github.io/live-demo/ and we'd need to run "grunt build" to produce the compressed to be committed for the actual site (which is hosted on Github pages).

[kirjs]

Trey, thanks for the reply, I updated the css, so you can see the result at: http://kcherkashin.github.io/live-demo/

Currently the textarea is not being resized for me in any browser: debugger says the code is trying to use forEach on a NodeList, which shouldn't work anywhere.

It should be an easy fix, let me take a quick look at it.

[kirjs]

Trey,

I'm looking at vquery.js file, it has a toArray function, which is never used anywhere.
I would expect that wrapping $.getByTag in it, or introducing something like $.getArrayByTag would be the cleanest way to fix the code.
What do you think?

[treyhunner]

I believe the line NodeList.prototype.forEach = Array.prototype.forEach; in vquery.js should fix that problem.

I'm surprised it doesn't work for you in Chrome because it works fine for me. Here's what it does:

[kirjs]

This sounds like a really interesting bug, I wonder if one of the browser plugins extends NodeList prototype in your browser.

NodeList.prototype.forEach = Array.prototype.forEach sounds live a valid solution, unless vquery.js is going to be used outside of the app.

[kirjs]

Hm, looks like it's my chrome which is special, which version do you have?
http://www.browserstack.com/screenshots/aa3e38c2ed70bb52537b2069d80bf9d667df6d27

[treyhunner]

33.0.1750.152 (Developer Build 256984) Ubuntu 13.10

[kirjs]

Just realized that in Chrome HTMLCollection is returned. The fix should look like this:

NodeList.prototype.forEach = Array.prototype.forEach;
HTMLCollection.prototype.forEach = Array.prototype.forEach;

[kirjs]

Trey,

I added the prototype hack to make forEach work,
disabled textarea resizing,
left some sensible default height for textarea (200px), which will be overridden if JS works.

http://kcherkashin.github.io/live-demo/

What do you think?