Repository navigation
Every sign-in needs its device key - #45
Merged
Merged
Conversation
Edka now issues no token without a proof of a device key, so a sign-in made before v0.10.0 needs edka login again, and EDKA_TOKEN, a bare access token, no longer authenticates. The security notes stop describing it.
camilb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edka now issues no CLI token without a proof of a device key. This updates
docs/security.md: a sign-in made before v0.10.0 needsedka loginagain, andEDKA_TOKEN(a bare access token) is no longer described, since it no longer authenticates. The variable still works against test servers; removing it from the code is a separate change.Note
Low Risk
Documentation-only changes with no code, auth, or runtime behavior in this diff.
Overview
Updates
docs/security.mdto match v0.10.0 CLI auth: Edka issues no token without a DPoP device-key proof, so pre-v0.10.0 sessions neededka loginagain instead of picking up a key on the next refresh.Removes the
EDKA_TOKENsection (bare access tokens are no longer documented as a supported auth path) and tightens the general statement that no CLI token works without its bound key and there are no long-lived M2M CLI tokens. In the GitHub Actions trust section, drops the rule aboutEDKA_TOKENandEDKA_TRUSTtogether and keeps only thatedka loginis refused whileEDKA_TRUSTis set.Reviewed by Cursor Bugbot for commit 861d2c1. Configure here.